third_party/WebKit/Source/core/paint/PaintLayer.cpp - Issue 1532923002: Add a Path::contains() version that use the Path's winding rule

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 1532923002: Add a Path::contains() version that use the Path's winding rule (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Forward declare Path in GC.h Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ClipPathOperation.h ('k') | third_party/WebKit/Source/core/style/SVGComputedStyle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp

index d06c55845492106e6a13d588229dff6155d54a19..d19defbd4862750dc61e387204c8a1444f7d2969 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp

@@ -1996,7 +1996,7 @@ bool PaintLayer::hitTestClippedOutByClipPath(PaintLayer* rootLayer, const HitTes

ASSERT(clipPathOperation);

if (clipPathOperation->type() == ClipPathOperation::SHAPE) {

ShapeClipPathOperation* clipPath = toShapeClipPathOperation(clipPathOperation);

- if (!clipPath->path(FloatRect(rootRelativeBounds)).contains(FloatPoint(hitTestLocation.point()), clipPath->windRule()))

+ if (!clipPath->path(FloatRect(rootRelativeBounds)).contains(FloatPoint(hitTestLocation.point())))

return true;

} else {

ASSERT(clipPathOperation->type() == ClipPathOperation::REFERENCE);