Add a Path::contains() version that use the Path's winding rule

Add a Path::contains() version that use the Path's winding rule

In preparation for using SkPath::contains() for Path::contains(), add an
overload that uses the winding rule (fill type) from the SkPath, since
that the version which will require less impedance matching with the
Skia API. Convert "obvious" current users to the new overload, and remove
some unused winding rule accessors.
Attempt to clean up some related includes while in the general area.

BUG=523102
Committed: https://crrev.com/c1e1dee348b45db5bc8e598d7c942a932594570c
Cr-Commit-Position: refs/heads/master@{#366080}

[fs, 2015-12-17 17:29:02]

Description was changed from

==========
Add a Path::contains() version that use the Path's winding rule

In preparation for using SkPath::contains() for Path::contains(), add an
overload that uses the winding rule (fill type) from the SkPath, since
that the version which will require less impedance matching with the
Skia API. Convert "obvious" current users to the new overload.
Attempt to clean up some related includes while in the general area.

BUG=523102
==========

to

==========
Add a Path::contains() version that use the Path's winding rule

In preparation for using SkPath::contains() for Path::contains(), add an
overload that uses the winding rule (fill type) from the SkPath, since
that the version which will require less impedance matching with the
Skia API. Convert "obvious" current users to the new overload, and remove
some unused winding rule accessors.
Attempt to clean up some related includes while in the general area.

BUG=523102
==========

[fs, 2015-12-17 19:28:09]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, junov@chromium.org, pdr@chromium.org

[pdr., 2015-12-17 19:30:18]

On 2015/12/17 at 19:28:09, fs wrote:
> 

LGTM

[f(malita), 2015-12-17 20:00:06]

lgtm

https://codereview.chromium.org/1532923002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/GraphicsContext.h (right):

https://codereview.chromium.org/1532923002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/GraphicsContext.h:39: #include
"platform/graphics/Path.h"
nit: would a fw-decl not work instead of full header?

[Justin Novosad, 2015-12-17 22:23:31]

lgtm

Thanks for the cleanup.

[fs, 2015-12-18 09:41:05]

https://codereview.chromium.org/1532923002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/GraphicsContext.h (right):

https://codereview.chromium.org/1532923002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/GraphicsContext.h:39: #include
"platform/graphics/Path.h"
On 2015/12/17 at 20:00:06, f(malita) wrote:
> nit: would a fw-decl not work instead of full header?

Yeah, not too much fallout from that. Done.

[fs, 2015-12-18 10:20:36]

The CQ bit was checked by fs@opera.com

[fs, 2015-12-18 10:20:36]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org,
fmalita@chromium.org, junov@chromium.org
Link to the patchset: https://codereview.chromium.org/1532923002/#ps40001
(title: "Forward declare Path in GC.h")

[commit-bot: I haz the power, 2015-12-18 10:20:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1532923002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1532923002/40001

[commit-bot: I haz the power, 2015-12-18 11:59:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-18 12:00:31]

Description was changed from

==========
Add a Path::contains() version that use the Path's winding rule

In preparation for using SkPath::contains() for Path::contains(), add an
overload that uses the winding rule (fill type) from the SkPath, since
that the version which will require less impedance matching with the
Skia API. Convert "obvious" current users to the new overload, and remove
some unused winding rule accessors.
Attempt to clean up some related includes while in the general area.

BUG=523102
==========

to

==========
Add a Path::contains() version that use the Path's winding rule

In preparation for using SkPath::contains() for Path::contains(), add an
overload that uses the winding rule (fill type) from the SkPath, since
that the version which will require less impedance matching with the
Skia API. Convert "obvious" current users to the new overload, and remove
some unused winding rule accessors.
Attempt to clean up some related includes while in the general area.

BUG=523102

Committed: https://crrev.com/c1e1dee348b45db5bc8e598d7c942a932594570c
Cr-Commit-Position: refs/heads/master@{#366080}
==========

[commit-bot: I haz the power, 2015-12-18 12:00:32]

Patchset 3 (id:??) landed as
https://crrev.com/c1e1dee348b45db5bc8e598d7c942a932594570c
Cr-Commit-Position: refs/heads/master@{#366080}