src/parsing/parser.cc - Issue 1532873004: [es6] enable destructuring rest parameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parsing/parser.cc

Issue 1532873004: [es6] enable destructuring rest parameters (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Update test262 expectations Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parsing/parser.cc

diff --git a/src/parsing/parser.cc b/src/parsing/parser.cc

index 335b23ad6599e3bbb534ecf19e9a491e639814e6..baff20e1d569ffd4249f674b0cdacff490057e4f 100644

--- a/src/parsing/parser.cc

+++ b/src/parsing/parser.cc

@@ -4478,7 +4478,7 @@ Block* Parser::BuildParameterInitializationBlock(

factory()->NewBlock(NULL, 1, true, RelocInfo::kNoPosition);

for (int i = 0; i < parameters.params.length(); ++i) {

auto parameter = parameters.params[i];

- if (parameter.is_rest) break;

+ if (parameter.is_rest && parameter.pattern->IsVariableProxy()) break;

DeclarationDescriptor descriptor;

descriptor.declaration_kind = DeclarationDescriptor::PARAMETER;

descriptor.parser = this;

« no previous file with comments | « no previous file | src/parsing/parser-base.h » ('j') | no next file with comments »