content/browser/frame_host/render_frame_host_manager.cc - Issue 1532873003: PlzNavigate: add initial traces for new TBM benchmarks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 1532873003: PlzNavigate: add initial traces for new TBM benchmarks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address CR comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/browser/loader/navigation_url_loader_impl.cc » ('j') | content/browser/loader/navigation_url_loader_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager.cc

diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc

index 835922622d748095c9df1ef48d695d5525742a5e..b1265924f764e87b78840ca08ca9a177c28a0fe7 100644

--- a/content/browser/frame_host/render_frame_host_manager.cc

+++ b/content/browser/frame_host/render_frame_host_manager.cc

@@ -377,7 +377,7 @@ RenderFrameHostImpl* RenderFrameHostManager::Navigate(

const GURL& dest_url,

const FrameNavigationEntry& frame_entry,

const NavigationEntryImpl& entry) {

- TRACE_EVENT1("navigation", "RenderFrameHostManager:Navigate",

+ TRACE_EVENT1("navigation", "RenderFrameHostManager::Navigate",

carlosk 2015/12/21 11:19:25 I reverted this change because I found references

"FrameTreeNode id", frame_tree_node_->frame_tree_node_id());

// Create a pending RenderFrameHost to use for the navigation.

RenderFrameHostImpl* dest_render_frame_host = UpdateStateForNavigate(