Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 1532873003: PlzNavigate: add initial traces for new TBM benchmarks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_dispatcher_host_impl.cc
diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc
index bffd3d6f4f93af729c7da4a72ca24fc02e6a0fb9..793f7e1d2d8667798bfb0460a18c8a9303871526 100644
--- a/content/browser/loader/resource_dispatcher_host_impl.cc
+++ b/content/browser/loader/resource_dispatcher_host_impl.cc
@@ -434,7 +434,7 @@ void LogResourceRequestTimeOnUI(
DCHECK_CURRENTLY_ON(BrowserThread::UI);
RenderFrameHostImpl* host =
RenderFrameHostImpl::FromID(render_process_id, render_frame_id);
- if (host != NULL) {
+ if (host != nullptr) {
DCHECK(host->frame_tree_node()->IsMainFrame());
host->frame_tree_node()->navigator()->LogResourceRequestTime(
timestamp, url);
@@ -1119,6 +1119,8 @@ void ResourceDispatcherHostImpl::OnRequestResource(
"477117 ResourceDispatcherHostImpl::OnRequestResource"));
// When logging time-to-network only care about main frame and non-transfer
// navigations.
+ // PlzNavigate: this log happens from |NavigationRequest::OnRequestStarted|
clamy 2015/12/18 15:42:11 nit: no ||? I think we prefer to use those for arg
carlosk 2015/12/18 17:23:21 Done.
+ // instead.
if (request_data.resource_type == RESOURCE_TYPE_MAIN_FRAME &&
request_data.transferred_request_request_id == -1 &&
!IsBrowserSideNavigationEnabled()) {

Powered by Google App Engine
This is Rietveld 408576698