Chromium Code Reviews| Index: content/browser/frame_host/render_frame_host_impl.cc |
| diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc |
| index 5d34a7916f96be79093fcfea5c00c67aaf56aef9..00a84b720b34d0d6a127c95aa9c039351a0fafb8 100644 |
| --- a/content/browser/frame_host/render_frame_host_impl.cc |
| +++ b/content/browser/frame_host/render_frame_host_impl.cc |
| @@ -1136,8 +1136,9 @@ void RenderFrameHostImpl::OnBeforeUnloadACK( |
| bool proceed, |
| const base::TimeTicks& renderer_before_unload_start_time, |
| const base::TimeTicks& renderer_before_unload_end_time) { |
| - TRACE_EVENT_ASYNC_END0( |
| - "navigation", "RenderFrameHostImpl::BeforeUnload", this); |
| + TRACE_EVENT_ASYNC_END1("navigation", "RenderFrameHostImpl BeforeUnload", this, |
|
clamy
2015/12/18 15:42:11
Is it an issue if this is called without the begin
carlosk
2015/12/18 17:23:21
From a tracing perspective no. I have to rely on t
|
| + "FrameTreeNode id", |
| + frame_tree_node_->frame_tree_node_id()); |
| DCHECK(!GetParent()); |
| // If this renderer navigated while the beforeunload request was in flight, we |
| // may have cleared this state in OnDidCommitProvisionalLoad, in which case we |
| @@ -1922,8 +1923,8 @@ void RenderFrameHostImpl::DispatchBeforeUnload(bool for_navigation) { |
| for_navigation, true, base::TimeTicks::Now()); |
| return; |
| } |
| - TRACE_EVENT_ASYNC_BEGIN0( |
| - "navigation", "RenderFrameHostImpl::BeforeUnload", this); |
| + TRACE_EVENT_ASYNC_BEGIN1("navigation", "RenderFrameHostImpl BeforeUnload", |
| + this, "&RenderFrameHostImpl", (void*)this); |
| // This may be called more than once (if the user clicks the tab close button |
| // several times, or if she clicks the tab close button then the browser close |