PlzNavigate: add initial traces for new TBM benchmarks.

content/browser/frame_host/navigation_request.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigation_request.h"
 
 #include "content/browser/frame_host/frame_tree.h"
 #include "content/browser/frame_host/frame_tree_node.h"
 #include "content/browser/frame_host/navigation_controller_impl.h"
 #include "content/browser/frame_host/navigation_handle_impl.h"
@@ skipping 263 matching lines @@
 void NavigationRequest::OnRequestFailed(bool has_stale_copy_in_cache,
                                         int net_error) {
   DCHECK(state_ == STARTED);
   state_ = FAILED;
   navigation_handle_->set_net_error_code(static_cast<net::Error>(net_error));
   frame_tree_node_->navigator()->FailedNavigation(
       frame_tree_node_, has_stale_copy_in_cache, net_error);
 }
 
 void NavigationRequest::OnRequestStarted(base::TimeTicks timestamp) {
+  if (frame_tree_node_->IsMainFrame()) {
+    TRACE_EVENT_ASYNC_END_WITH_TIMESTAMP0(

[clamy, 2015/12/18 15:42:11]

I'm not sure about the naming of the measurement - start may be a bit vague. For
exemple, do we register the trace when the net stack receives the request or
when the various throttles have executed and the network request actually
starts?

[carlosk, 2015/12/18 17:23:21]

Looking at the code this is triggered from, it happens along with the call to
ResourceDispatcherHostImpl::BeginNavigationRequest which checks with
ResourceHandlers (that go through the throttles as well). So it's before the net
stack actually starts.

It seems this is OK as a point of measurement but I agree we might need to
rename it in this case. I'm thinking "Navigation timeToIOStartBeforeThrottles"
but I'm all ears for better ideas.

Another option is to move this further down so that this is tracked after the
handlers/throttlers. Or even adding another measurement at that point.

[clamy, 2015/12/21 10:43:32]

I'm fine with the measurement happening when it happens. For the name, maybe
timeToNetworkStack (I'm not very fond of it either - hopefully Nasko will have
better ideas).

[carlosk, 2015/12/21 11:19:25]

Done.

+        "navigation", "Navigation timeToIOStart", navigation_handle_.get(),
+        timestamp.ToInternalValue());
+  }
   frame_tree_node_->navigator()->LogResourceRequestTime(timestamp,
                                                         common_params_.url);
 }
 
 void NavigationRequest::OnStartChecksComplete(
     NavigationThrottle::ThrottleCheckResult result) {
   CHECK(result != NavigationThrottle::DEFER);
 
   // Abort the request if needed. This will destroy the NavigationRequest.
   if (result == NavigationThrottle::CANCEL_AND_IGNORE ||
@@ skipping 48 matching lines @@
       browser_context, navigating_frame_host->GetSiteInstance());
   DCHECK(partition);
 
   ServiceWorkerContextWrapper* service_worker_context =
       static_cast<ServiceWorkerContextWrapper*>(
           partition->GetServiceWorkerContext());
   navigation_handle_->InitServiceWorkerHandle(service_worker_context);
 }
 
 }  // namespace content