Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1532793002: Fix fuzzy infobar shadow on Nexus 5X. (Closed)

Created:
5 years ago by newt (away)
Modified:
5 years ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix fuzzy infobar shadow on Nexus 5X. On Nexus 5X, Nexus 7, and other devices that don't use one of the standard densities (mdpi, hdpi, etc), the top of the infobar faded from white to gray (over a few pixel rows) instead of having an immediate jump from white to gray. This happened because the 9-patch infobar background was resized, causing the sharp edge to become blurry. As a fix, this CL uses a layer list as the infobar background with two layers: a bitmap for the infobar shadow, and solid white the rest of the background. Using a layer list ensures that the infobar shadow's bounds will be pixel-aligned. BUG=396223 Committed: https://crrev.com/eb982c360e64e4af001ff80fe67a29b971928b4b Cr-Commit-Position: refs/heads/master@{#365725}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
newt (away)
PTAL
5 years ago (2015-12-17 01:37:24 UTC) #2
gone
lgtm
5 years ago (2015-12-17 01:42:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532793002/1
5 years ago (2015-12-17 03:10:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 03:50:11 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-17 03:51:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb982c360e64e4af001ff80fe67a29b971928b4b
Cr-Commit-Position: refs/heads/master@{#365725}

Powered by Google App Engine
This is Rietveld 408576698