Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 1532763002: Fixes to mock SDK to enable dart:core to be summarized. (Closed)

Created:
5 years ago by Paul Berry
Modified:
5 years ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes to mock SDK to enable dart:core to be summarized. This CL makes the following changes to the mock SDK used by AnalysisContextFactory.initContextWithCore: - Getters created by the ElementFactory have their `synthetic` property set correctly, and their corresponding synthetic fields have their `final` property set correctly. - The following class elements all have at least one constructor: Function, Iterable, Iterator, Map, Null, StackTrace, Type, num, double, _Proxy. This allows resynthesize_test.dart's `test_core` to pass. Also, some minor improvements are made to resynthesize_test.dart to allow failures to be diagnosed more easily. R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/80fc29cecd64aca41e5f5f492a4bebdda0c66367

Patch Set 1 #

Patch Set 2 : Remove a bogus comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -43 lines) Patch
M pkg/analyzer/lib/src/generated/testing/element_factory.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/test_type_provider.dart View 12 chunks +53 lines, -21 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 5 chunks +15 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
5 years ago (2015-12-16 23:28:26 UTC) #2
Brian Wilkerson
LGTM
5 years ago (2015-12-16 23:43:40 UTC) #3
scheglov
LGTM
5 years ago (2015-12-16 23:46:36 UTC) #4
Paul Berry
5 years ago (2015-12-17 15:19:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
80fc29cecd64aca41e5f5f492a4bebdda0c66367 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698