Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 153273005: libwep: cherry-pick fix for compilation to arm64 (Closed)

Created:
6 years, 10 months ago by sdefresne
Modified:
6 years, 10 months ago
CC:
chromium-reviews, urvang (Google), jzern, skal, vikasa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

libwep: cherry-pick fix for compilation to arm64 c1cb193 disable NEON for arm64 platform BUG=314720, 342387 R=urvang@google.com TBR=cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251047

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix order of the patch descriptions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/libwebp/README.chromium View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libwebp/dsp/dsp.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
sdefresne
urvang: PTAL cpu: TBR as advised in the third_party/OWNERS file
6 years, 10 months ago (2014-02-11 13:43:00 UTC) #1
skal
lgtm
6 years, 10 months ago (2014-02-11 15:37:36 UTC) #2
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 10 months ago (2014-02-12 17:59:49 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 18:00:31 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-12 18:00:31 UTC) #5
urvang (Google)
LGTM I don't think any of the bots use ARM64, so I'm assuming this was ...
6 years, 10 months ago (2014-02-12 19:28:52 UTC) #6
sdefresne
Thank you for the review. Yes this was tested manually. https://codereview.chromium.org/153273005/diff/1/third_party/libwebp/README.chromium File third_party/libwebp/README.chromium (right): https://codereview.chromium.org/153273005/diff/1/third_party/libwebp/README.chromium#newcode24 ...
6 years, 10 months ago (2014-02-13 10:21:52 UTC) #7
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 10 months ago (2014-02-13 10:22:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/153273005/150001
6 years, 10 months ago (2014-02-13 10:22:38 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 16:14:29 UTC) #10
Message was sent while issue was closed. 
Change committed as 251047

Powered by Google App Engine
This is Rietveld 408576698