Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4386)

Unified Diff: chrome/browser/omaha_query_params/omaha_query_params.h

Issue 153273002: Include the language (locale) info in the update ping (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments, Unittest Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/omaha_query_params/OWNERS ('k') | chrome/browser/omaha_query_params/omaha_query_params.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/omaha_query_params/omaha_query_params.h
diff --git a/chrome/common/omaha_query_params/omaha_query_params.h b/chrome/browser/omaha_query_params/omaha_query_params.h
similarity index 74%
rename from chrome/common/omaha_query_params/omaha_query_params.h
rename to chrome/browser/omaha_query_params/omaha_query_params.h
index 145d9ee17568d8cbd2aee52849a1f9bc6c0a29bf..9dfc9ed73ef2dfec9b38438993d7323ead4dc60b 100644
--- a/chrome/common/omaha_query_params/omaha_query_params.h
+++ b/chrome/browser/omaha_query_params/omaha_query_params.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_COMMON_OMAHA_QUERY_PARAMS_OMAHA_QUERY_PARAMS_H_
-#define CHROME_COMMON_OMAHA_QUERY_PARAMS_OMAHA_QUERY_PARAMS_H_
+#ifndef CHROME_BROWSER_OMAHA_QUERY_PARAMS_OMAHA_QUERY_PARAMS_H_
+#define CHROME_BROWSER_OMAHA_QUERY_PARAMS_OMAHA_QUERY_PARAMS_H_
#include <string>
@@ -20,7 +20,7 @@ class OmahaQueryParams {
// Generates a string of URL query paramaters to be used when getting
// component and extension updates. Includes the following fields: os, arch,
- // prod, prodchannel, prodversion.
+ // prod, prodchannel, prodversion, lang.
static std::string Get(ProdId prod);
// Returns the value we use for the "prod=" parameter. Possible return values
@@ -29,27 +29,31 @@ class OmahaQueryParams {
// Returns the value we use for the "os=" parameter. Possible return values
// include: "mac", "win", "android", "cros", "linux", and "openbsd".
- static const char* getOS();
+ static const char* GetOS();
// Returns the value we use for the "arch=" parameter. Possible return values
// include: "x86", "x64", and "arm".
- static const char* getArch();
+ static const char* GetArch();
// Returns the value we use for the "nacl_arch" parameter. Note that this may
// be different from the "arch" parameter above (e.g. one may be 32-bit and
// the other 64-bit). Possible return values include: "x86-32", "x86-64",
// "arm", and "mips32".
- static const char* getNaclArch();
+ static const char* GetNaclArch();
// Returns the value we use for the "updaterchannel=" and "prodchannel="
// parameters. Possible return values include: "canary", "dev", "beta", and
// "stable".
static const char* GetChannelString();
+ // Returns the language for the present locale. Possible return values are
+ // standard tags for languages, such as "en", "en-US", "de", "fr", "af", etc.
+ static const char* GetLang();
+
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(OmahaQueryParams);
};
} // namespace chrome
-#endif // CHROME_COMMON_OMAHA_QUERY_PARAMS_OMAHA_QUERY_PARAMS_H_
+#endif // CHROME_BROWSER_OMAHA_QUERY_PARAMS_OMAHA_QUERY_PARAMS_H_
« no previous file with comments | « chrome/browser/omaha_query_params/OWNERS ('k') | chrome/browser/omaha_query_params/omaha_query_params.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698