chrome/browser/extensions/api/runtime/runtime_api.cc - Issue 153273002: Include the language (locale) info in the update ping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/runtime/runtime_api.cc

Issue 153273002: Include the language (locale) info in the update ping (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments, Unittest Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/pnacl/pnacl_component_installer.cc ('k') | chrome/browser/extensions/updater/extension_updater_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/runtime/runtime_api.cc

diff --git a/chrome/browser/extensions/api/runtime/runtime_api.cc b/chrome/browser/extensions/api/runtime/runtime_api.cc

index 9953abe92fe434f167647075edf92609b2be44b7..682b62cc9cf7be8f7c027e2e640dee658dd0dcb0 100644

--- a/chrome/browser/extensions/api/runtime/runtime_api.cc

+++ b/chrome/browser/extensions/api/runtime/runtime_api.cc

@@ -14,13 +14,13 @@

#include "chrome/browser/extensions/extension_host.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/updater/extension_updater.h"

+#include "chrome/browser/omaha_query_params/omaha_query_params.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/profiles/profile_manager.h"

#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/browser_navigator.h"

#include "chrome/browser/ui/browser_window.h"

#include "chrome/common/extensions/api/runtime.h"

-#include "chrome/common/omaha_query_params/omaha_query_params.h"

#include "content/public/browser/child_process_security_policy.h"

#include "content/public/browser/notification_service.h"

#include "content/public/browser/render_process_host.h"

@@ -521,7 +521,7 @@ bool RuntimeRestartFunction::RunImpl() {

bool RuntimeGetPlatformInfoFunction::RunImpl() {

GetPlatformInfo::Results::PlatformInfo info;

- const char* os = chrome::OmahaQueryParams::getOS();

+ const char* os = chrome::OmahaQueryParams::GetOS();

if (strcmp(os, "mac") == 0) {

info.os = GetPlatformInfo::Results::PlatformInfo::OS_MAC_;

} else if (strcmp(os, "win") == 0) {

@@ -539,7 +539,7 @@ bool RuntimeGetPlatformInfoFunction::RunImpl() {

return false;

}

- const char* arch = chrome::OmahaQueryParams::getArch();

+ const char* arch = chrome::OmahaQueryParams::GetArch();

if (strcmp(arch, "arm") == 0) {

info.arch = GetPlatformInfo::Results::PlatformInfo::ARCH_ARM;

} else if (strcmp(arch, "x86") == 0) {

@@ -551,7 +551,7 @@ bool RuntimeGetPlatformInfoFunction::RunImpl() {

return false;

}

- const char* nacl_arch = chrome::OmahaQueryParams::getNaclArch();

+ const char* nacl_arch = chrome::OmahaQueryParams::GetNaclArch();

if (strcmp(nacl_arch, "arm") == 0) {

info.nacl_arch = GetPlatformInfo::Results::PlatformInfo::NACL_ARCH_ARM;

} else if (strcmp(nacl_arch, "x86-32") == 0) {