Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: chrome/browser/extensions/updater/manifest_fetch_data.cc

Issue 153273002: Include the language (locale) info in the update ping (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments, Unittest Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/updater/manifest_fetch_data.h" 5 #include "chrome/browser/extensions/updater/manifest_fetch_data.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/metrics/histogram.h" 10 #include "base/metrics/histogram.h"
11 #include "base/strings/string_number_conversions.h" 11 #include "base/strings/string_number_conversions.h"
12 #include "base/strings/string_util.h" 12 #include "base/strings/string_util.h"
13 #include "chrome/browser/google/google_util.h" 13 #include "chrome/browser/google/google_util.h"
14 #include "chrome/browser/metrics/metrics_service.h" 14 #include "chrome/browser/metrics/metrics_service.h"
15 #include "chrome/common/omaha_query_params/omaha_query_params.h" 15 #include "chrome/browser/omaha_query_params/omaha_query_params.h"
16 #include "net/base/escape.h" 16 #include "net/base/escape.h"
17 17
18 namespace { 18 namespace {
19 19
20 // Maximum length of an extension manifest update check url, since it is a GET 20 // Maximum length of an extension manifest update check url, since it is a GET
21 // request. We want to stay under 2K because of proxies, etc. 21 // request. We want to stay under 2K because of proxies, etc.
22 const int kExtensionsManifestMaxURLSize = 2000; 22 const int kExtensionsManifestMaxURLSize = 2000;
23 23
24 } // namespace 24 } // namespace
25 25
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 NOTREACHED(); 154 NOTREACHED();
155 return value == kNeverPinged || value > 0; 155 return value == kNeverPinged || value > 0;
156 } 156 }
157 157
158 void ManifestFetchData::Merge(const ManifestFetchData& other) { 158 void ManifestFetchData::Merge(const ManifestFetchData& other) {
159 DCHECK(full_url() == other.full_url()); 159 DCHECK(full_url() == other.full_url());
160 request_ids_.insert(other.request_ids_.begin(), other.request_ids_.end()); 160 request_ids_.insert(other.request_ids_.begin(), other.request_ids_.end());
161 } 161 }
162 162
163 } // namespace extensions 163 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/updater/extension_updater_unittest.cc ('k') | chrome/browser/extensions/webstore_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698