Include the language (locale) info in the update ping

chrome/browser/extensions/updater/manifest_fetch_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/updater/manifest_fetch_data.h"
 
 #include <vector>
 
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
+#include "chrome/browser/browser_process.h"
 #include "chrome/browser/google/google_util.h"
 #include "chrome/browser/metrics/metrics_service.h"
 #include "chrome/common/omaha_query_params/omaha_query_params.h"
 #include "net/base/escape.h"
 
 namespace {
 
 // Maximum length of an extension manifest update check url, since it is a GET
 // request. We want to stay under 2K because of proxies, etc.
 const int kExtensionsManifestMaxURLSize = 2000;
@@ skipping 47 matching lines @@
     NOTREACHED() << "Duplicate extension id " << id;
     return false;
   }
 
   // Compute the string we'd append onto the full_url_, and see if it fits.
   std::vector<std::string> parts;
   parts.push_back("id=" + id);
   parts.push_back("v=" + version);
   if (!install_source.empty())
     parts.push_back("installsource=" + install_source);
+  parts.push_back("lang=" + g_browser_process->GetApplicationLocale());

[Devlin, 2014/02/04 00:18:39]

This is also done here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...

Would it make sense to put this into OmahaQueryParams at all?

[Marijn Kruisselbrink, 2014/02/10 21:06:46]

I'm not entirely sure what you're suggesting putting in OmahaQueryParams? But
yeah, it definitely looks like it might make sense to share something between
this place and WebstoreInstaller.

[Devlin, 2014/02/10 23:08:15]

The OmahaQueryParams class is where we're getting most of the parameters we're
using, like architecture, os, etc.  It seems like "lang" might be a good fit
there, since it's now used in both places.

+cpu for his thoughts.

   parts.push_back("uc");
 
   if (!update_url_data.empty()) {
     // Make sure the update_url_data string is escaped before using it so that
     // there is no chance of overriding the id or v other parameter value
     // we place into the x= value.
     parts.push_back("ap=" + net::EscapeQueryParamValue(update_url_data, true));
   }
 
   // Append brand code, rollcall and active ping parameters.
@@ skipping 64 matching lines @@
     NOTREACHED();
   return value == kNeverPinged || value > 0;
 }
 
 void ManifestFetchData::Merge(const ManifestFetchData& other) {
   DCHECK(full_url() == other.full_url());
   request_ids_.insert(other.request_ids_.begin(), other.request_ids_.end());
 }
 
 }  // namespace extensions