Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1532643004: Remove unused #include. (Closed)

Created:
5 years ago by davidben
Modified:
5 years ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused #include. base/sha1.h isn't being used by base/metrics/field_trial.cc anymore. BUG=none Committed: https://crrev.com/aa631be35d44bf63942ff52e3e7f337ce70d18c1 Cr-Commit-Position: refs/heads/master@{#365724}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M base/metrics/field_trial.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
davidben
I was checking on who used that header and noticed that this file doesn't actually ...
5 years ago (2015-12-17 01:05:46 UTC) #2
Ilya Sherman
LGTM
5 years ago (2015-12-17 01:08:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532643004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532643004/1
5 years ago (2015-12-17 02:36:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 03:49:48 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-17 03:51:31 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/aa631be35d44bf63942ff52e3e7f337ce70d18c1
Cr-Commit-Position: refs/heads/master@{#365724}

Powered by Google App Engine
This is Rietveld 408576698