Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1532643003: Remove and Add the mutator thread from the active thread list when unscheduling and scheduling the … (Closed)

Created:
5 years ago by siva
Modified:
5 years ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove and Add the mutator thread from the active thread list when unscheduling and scheduling the thread on an isolate, this ensures that we do not extra count the mutator thread even after it is unscheduled during safepoint operation. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/e2f9217dc0718051970328af90cbd0a9d98d079b

Patch Set 1 #

Patch Set 2 : self-review-comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -22 lines) Patch
M runtime/vm/thread_registry.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/thread_registry.cc View 1 6 chunks +39 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
5 years ago (2015-12-16 19:28:20 UTC) #2
srdjan
lgtm
5 years ago (2015-12-16 19:33:28 UTC) #3
siva
5 years ago (2015-12-16 20:43:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e2f9217dc0718051970328af90cbd0a9d98d079b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698