Issue 153263006: Add test for ChromeVox injection into webview

Issue 153263006: Add test for ChromeVox injection into webview (Closed)

Created:
6 years, 10 months ago by Dmitry Polukhin

Modified:
6 years, 10 months ago

Reviewers:
Fady Samuel, Peter Lundblad

CC:
chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add test for ChromeVox injection into webview TEST=browser_tests BUG=342546 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251148

Patch Set 1 #

Patch Set 2 : fix clang compilation #

Patch Set 3 : more fixes #

Total comments: 2

Patch Set 4 : comment fixed #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+181 lines, -90 lines)			Patch
M	chrome/browser/apps/web_view_browsertest.cc	View	1	2 chunks	+25 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/accessibility/speech_monitor.h	View	1 2 3	1 chunk	+59 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/accessibility/speech_monitor.cc	View	1 2	1 chunk	+81 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc	View		5 chunks	+4 lines, -83 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3	2 chunks	+4 lines, -0 lines	0 comments	Download
A +	chrome/test/data/extensions/platform_apps/web_view/chromevox_injection/guest.html	View		1 chunk	+3 lines, -2 lines	0 comments	Download
A +	chrome/test/data/extensions/platform_apps/web_view/chromevox_injection/main.html	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/test/data/extensions/platform_apps/web_view/chromevox_injection/main.js	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	chrome/test/data/extensions/platform_apps/web_view/chromevox_injection/manifest.json	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/test/data/extensions/platform_apps/web_view/chromevox_injection/test.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Peter Lundblad

lgtm Cool, just aminor nit from me. //Peter https://codereview.chromium.org/153263006/diff/180001/chrome/browser/chromeos/accessibility/speech_monitor.h File chrome/browser/chromeos/accessibility/speech_monitor.h (right): https://codereview.chromium.org/153263006/diff/180001/chrome/browser/chromeos/accessibility/speech_monitor.h#newcode16 chrome/browser/chromeos/accessibility/speech_monitor.h:16: // ...

6 years, 10 months ago (2014-02-13 01:06:01 UTC) #2

Dmitry Polukhin

https://codereview.chromium.org/153263006/diff/180001/chrome/browser/chromeos/accessibility/speech_monitor.h File chrome/browser/chromeos/accessibility/speech_monitor.h (right): https://codereview.chromium.org/153263006/diff/180001/chrome/browser/chromeos/accessibility/speech_monitor.h#newcode16 chrome/browser/chromeos/accessibility/speech_monitor.h:16: // Installs itself as the platform speech synthesis engine, ...

6 years, 10 months ago (2014-02-13 01:36:32 UTC) #3

Dmitry Polukhin

The CQ bit was checked by dpolukhin@chromium.org

6 years, 10 months ago (2014-02-13 19:01:06 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/153263006/270001

6 years, 10 months ago (2014-02-13 19:02:48 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/153263006/270001

6 years, 10 months ago (2014-02-13 20:01:33 UTC) #8

Message was sent while issue was closed.

Change committed as 251148

Expand Messages | Collapse Messages