net/dns/dns_response.cc - Issue 15326002: Fix bug in InitParseWithoutQuestion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/dns_response.cc

Issue 15326002: Fix bug in InitParseWithoutQuestion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/dns/dns_response.cc

diff --git a/net/dns/dns_response.cc b/net/dns/dns_response.cc

index 4a3371c2adb1b42b267f7a1c161ca58f191f94f4..5102d00cadabca036228df151c3c31265d612fb0 100644

--- a/net/dns/dns_response.cc

+++ b/net/dns/dns_response.cc

@@ -190,7 +190,9 @@ bool DnsResponse::InitParse(int nbytes, const DnsQuery& query) {

}

bool DnsResponse::InitParseWithoutQuery(int nbytes) {

- if (nbytes >= io_buffer_->size())

+ if (nbytes < 0 ||

szym 2013/05/17 20:43:21 nbytes < 0 is an error. You should probably DCHECK

Noam Samuel 2013/05/17 20:52:44 Done.

+ (unsigned)nbytes < sizeof(dns_protocol::Header) ||

+ nbytes >= io_buffer_->size())

return false;

size_t hdr_size = sizeof(dns_protocol::Header);

« no previous file with comments | « no previous file | net/dns/dns_response_unittest.cc » ('j') | no next file with comments »