Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1341)

Issue 1532573003: Fix UTC offset computation in date parser. (Closed)

Created:
5 years ago by Igor Sheludko
Modified:
5 years ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix UTC offset computation in date parser. BUG=chromium:561973 LOG=N Committed: https://crrev.com/37b5ebc31dfaa86ef32c703efc9a5671a5860815 Cr-Commit-Position: refs/heads/master@{#32956}

Patch Set 1 #

Patch Set 2 : Addressing comments #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M src/dateparser.cc View 1 2 1 chunk +9 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-561973.js View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532573003/1
5 years ago (2015-12-17 09:15:42 UTC) #2
Igor Sheludko
PTAL
5 years ago (2015-12-17 09:15:51 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-17 09:39:35 UTC) #6
Jakob Kummerow
lgtm
5 years ago (2015-12-17 12:52:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532573003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532573003/20001
5 years ago (2015-12-17 13:04:57 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/11176)
5 years ago (2015-12-17 13:12:29 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532573003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532573003/40001
5 years ago (2015-12-17 13:17:02 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-17 13:54:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532573003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532573003/40001
5 years ago (2015-12-17 16:28:08 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-17 16:29:21 UTC) #19
commit-bot: I haz the power
5 years ago (2015-12-17 16:29:43 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/37b5ebc31dfaa86ef32c703efc9a5671a5860815
Cr-Commit-Position: refs/heads/master@{#32956}

Powered by Google App Engine
This is Rietveld 408576698