Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1532513002: [wasm] Fixed FxxNeg for inputs of NaN. (Closed)

Created:
5 years ago by ahaas
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fixed FxxNeg for inputs of NaN. The new implementation also changes the sign bit if the input is NaN. (https://github.com/WebAssembly/v8-native-prototype/issues/99) R=bradnelson@chromium.org Committed: https://crrev.com/7ae140fe91b55a740b62e371b9bb6cb4d9801b53 Cr-Commit-Position: refs/heads/master@{#32894}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -14 lines) Patch
M src/compiler/wasm-compiler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 3 chunks +32 lines, -4 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 2 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
ahaas
5 years ago (2015-12-16 09:43:35 UTC) #1
bradnelson
lgtm
5 years ago (2015-12-16 10:00:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532513002/1
5 years ago (2015-12-16 10:00:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532513002/1
5 years ago (2015-12-16 10:04:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9014)
5 years ago (2015-12-16 10:23:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532513002/1
5 years ago (2015-12-16 11:30:02 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9019)
5 years ago (2015-12-16 11:32:10 UTC) #13
bradn
lgtm
5 years ago (2015-12-16 11:34:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532513002/1
5 years ago (2015-12-16 11:34:36 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9022)
5 years ago (2015-12-16 11:36:40 UTC) #18
Michael Starzinger
LGTM.
5 years ago (2015-12-16 11:42:15 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532513002/1
5 years ago (2015-12-16 11:43:39 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 11:44:50 UTC) #23
commit-bot: I haz the power
5 years ago (2015-12-16 11:45:36 UTC) #25
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ae140fe91b55a740b62e371b9bb6cb4d9801b53
Cr-Commit-Position: refs/heads/master@{#32894}

Powered by Google App Engine
This is Rietveld 408576698