Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6948)

Unified Diff: chrome/test/data/webui/settings/fake_settings_private.js

Issue 1532503003: Add FakeChromeEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/fake_settings_private.js
diff --git a/chrome/test/data/webui/settings/fake_settings_private.js b/chrome/test/data/webui/settings/fake_settings_private.js
index 63b321f82bad959e4a96c4a150593d93a4a64590..42ca4516964be06601c0eec4f1f6f9c28b997ea5 100644
--- a/chrome/test/data/webui/settings/fake_settings_private.js
+++ b/chrome/test/data/webui/settings/fake_settings_private.js
@@ -24,12 +24,6 @@ cr.define('settings', function() {
function FakeSettingsPrivate(opt_initialPrefs) {
this.prefs = {};
- // Hack alert: bind this instance's onPrefsChanged members to this.
- this.onPrefsChanged = {
- addListener: this.onPrefsChanged.addListener.bind(this),
- removeListener: this.onPrefsChanged.removeListener.bind(this),
- };
-
if (!opt_initialPrefs)
return;
for (var pref of opt_initialPrefs)
@@ -38,15 +32,7 @@ cr.define('settings', function() {
FakeSettingsPrivate.prototype = {
// chrome.settingsPrivate overrides.
- onPrefsChanged: {
- addListener: function(listener) {
- this.listener_ = listener;
- },
-
- removeListener: function(listener) {
- this.listener_ = null;
- },
- },
+ onPrefsChanged: new FakeChromeEvent(),
getAllPrefs: function(callback) {
// Send a copy of prefs to keep our internal state private.
@@ -104,7 +90,7 @@ cr.define('settings', function() {
},
/**
- * Notifies the listener of pref changes.
+ * Notifies the listeners of pref changes.
* @param {!Object<{key: string, value: *}>} changes
*/
sendPrefChanges: function(changes) {
@@ -115,7 +101,7 @@ cr.define('settings', function() {
pref.value = change.value;
prefs.push(deepCopy(pref));
}
- this.listener_(prefs);
+ this.onPrefsChanged.callListeners(prefs);
},
// Private methods for use by the fake API.

Powered by Google App Engine
This is Rietveld 408576698