Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/compiler/verifier.cc

Issue 1532503002: [turbofan] Fix type of JSCreateClosure to be Function. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 498 matching lines...) Expand 10 before | Expand all | Expand 10 after
509 case IrOpcode::kJSCreateArguments: 509 case IrOpcode::kJSCreateArguments:
510 // Type is OtherObject. 510 // Type is OtherObject.
511 CheckUpperIs(node, Type::OtherObject()); 511 CheckUpperIs(node, Type::OtherObject());
512 break; 512 break;
513 case IrOpcode::kJSCreateArray: 513 case IrOpcode::kJSCreateArray:
514 // Type is OtherObject. 514 // Type is OtherObject.
515 CheckUpperIs(node, Type::OtherObject()); 515 CheckUpperIs(node, Type::OtherObject());
516 break; 516 break;
517 case IrOpcode::kJSCreateClosure: 517 case IrOpcode::kJSCreateClosure:
518 // Type is Function. 518 // Type is Function.
519 CheckUpperIs(node, Type::OtherObject()); 519 CheckUpperIs(node, Type::Function());
520 break; 520 break;
521 case IrOpcode::kJSCreateLiteralArray: 521 case IrOpcode::kJSCreateLiteralArray:
522 case IrOpcode::kJSCreateLiteralObject: 522 case IrOpcode::kJSCreateLiteralObject:
523 case IrOpcode::kJSCreateLiteralRegExp: 523 case IrOpcode::kJSCreateLiteralRegExp:
524 // Type is OtherObject. 524 // Type is OtherObject.
525 CheckUpperIs(node, Type::OtherObject()); 525 CheckUpperIs(node, Type::OtherObject());
526 break; 526 break;
527 case IrOpcode::kJSLoadProperty: 527 case IrOpcode::kJSLoadProperty:
528 case IrOpcode::kJSLoadNamed: 528 case IrOpcode::kJSLoadNamed:
529 case IrOpcode::kJSLoadGlobal: 529 case IrOpcode::kJSLoadGlobal:
(...skipping 722 matching lines...) Expand 10 before | Expand all | Expand 10 after
1252 replacement->op()->EffectOutputCount() > 0); 1252 replacement->op()->EffectOutputCount() > 0);
1253 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1253 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1254 replacement->opcode() == IrOpcode::kFrameState); 1254 replacement->opcode() == IrOpcode::kFrameState);
1255 } 1255 }
1256 1256
1257 #endif // DEBUG 1257 #endif // DEBUG
1258 1258
1259 } // namespace compiler 1259 } // namespace compiler
1260 } // namespace internal 1260 } // namespace internal
1261 } // namespace v8 1261 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698