Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1532503002: [turbofan] Fix type of JSCreateClosure to be Function. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix type of JSCreateClosure to be Function. The JSCreateClosure operator always produces a function, so the type should reflect that. R=yangguo@chromium.org Committed: https://crrev.com/fe104b0dc3e32fdcaa366556d52b7a61dacf841b Cr-Commit-Position: refs/heads/master@{#32881}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/compiler/typer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years ago (2015-12-16 07:48:07 UTC) #1
Benedikt Meurer
Hey Yang, Here's a trivial typing fix for closure creation. Please take a look. Thanks, ...
5 years ago (2015-12-16 07:48:42 UTC) #2
Yang
On 2015/12/16 07:48:42, Benedikt Meurer wrote: > Hey Yang, > > Here's a trivial typing ...
5 years ago (2015-12-16 07:49:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532503002/1
5 years ago (2015-12-16 07:49:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 08:13:37 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-16 08:13:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe104b0dc3e32fdcaa366556d52b7a61dacf841b
Cr-Commit-Position: refs/heads/master@{#32881}

Powered by Google App Engine
This is Rietveld 408576698