Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1532493002: [runtime] Remove two obsolete intrinsics. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove two obsolete intrinsics. The %HeapObjectGetMap and %MapGetInstanceType intrinsics are obsolete because they are unsafe, so we can drop the code. R=yangguo@chromium.org Committed: https://crrev.com/b742026a2291e9a316264446d3fbf9e03065eb29 Cr-Commit-Position: refs/heads/master@{#32882}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -67 lines) Patch
M src/compiler/js-intrinsic-lowering.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 4 chunks +0 lines, -23 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M test/cctest/compiler/test-run-intrinsics.cc View 2 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
5 years ago (2015-12-16 07:36:07 UTC) #1
Benedikt Meurer
Hey Yang, Red-only cleanup. Please take a look. Thanks, Benedikt
5 years ago (2015-12-16 07:36:47 UTC) #2
Yang
On 2015/12/16 07:36:47, Benedikt Meurer wrote: > Hey Yang, > > Red-only cleanup. > Please ...
5 years ago (2015-12-16 07:36:57 UTC) #3
Yang
On 2015/12/16 07:36:47, Benedikt Meurer wrote: > Hey Yang, > > Red-only cleanup. > Please ...
5 years ago (2015-12-16 07:36:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532493002/1
5 years ago (2015-12-16 07:37:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 08:26:22 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-16 08:26:41 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b742026a2291e9a316264446d3fbf9e03065eb29
Cr-Commit-Position: refs/heads/master@{#32882}

Powered by Google App Engine
This is Rietveld 408576698