Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1532463003: ServiceWorker: Reject SecurityError instead of NotSupportedError. (Closed)

Created:
5 years ago by zino
Modified:
5 years ago
Reviewers:
falken, nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, falken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Reject SecurityError instead of NotSupportedError. According to the spec[1], we should reject SecurityError rather than NotSupportedError if client is not a secure context. [1] https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html BUG=570231 Committed: https://crrev.com/f133df216f18a91227ec716542ae8c5e5c8e16ed Cr-Commit-Position: refs/heads/master@{#365507}

Patch Set 1 #

Patch Set 2 : #

Messages

Total messages: 12 (6 generated)
zino
PTAL
5 years ago (2015-12-16 07:20:12 UTC) #3
nhiroki
On 2015/12/16 07:20:12, zino wrote: > PTAL LGTM. Can you file an issue for this ...
5 years ago (2015-12-16 07:50:28 UTC) #4
zino
On 2015/12/16 07:50:28, nhiroki wrote: > On 2015/12/16 07:20:12, zino wrote: > > PTAL > ...
5 years ago (2015-12-16 07:56:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532463003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532463003/20001
5 years ago (2015-12-16 08:13:10 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-16 09:08:46 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-16 09:09:48 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f133df216f18a91227ec716542ae8c5e5c8e16ed
Cr-Commit-Position: refs/heads/master@{#365507}

Powered by Google App Engine
This is Rietveld 408576698