Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1532463002: Revert of Enforce ordering in FilterTestNames. (Closed)

Created:
5 years ago by alexandermont
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enforce ordering in FilterTestNames. (patchset #5 id:80001 of https://codereview.chromium.org/1522303002/ ) Reason for revert: causing test failures Original issue's description: > Enforce ordering in FilterTestNames. > > BUG=569723 > > Committed: https://crrev.com/daeb80935df8b1532de2cf12879ea3d40a0615ae > Cr-Commit-Position: refs/heads/master@{#365376} TBR=jbudorick@chromium.org,mikecase@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=569723 Committed: https://crrev.com/005afed80274bf93a2ddc853c64baf3875367e7b Cr-Commit-Position: refs/heads/master@{#365409}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M build/util/lib/common/unittest_util.py View 1 chunk +14 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
alexandermont
Created Revert of Enforce ordering in FilterTestNames.
5 years ago (2015-12-16 00:47:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532463002/1
5 years ago (2015-12-16 00:49:00 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years ago (2015-12-16 00:49:02 UTC) #4
jbudorick
lgtm
5 years ago (2015-12-16 00:50:37 UTC) #5
alexandermont
5 years ago (2015-12-16 00:51:17 UTC) #7
mikecase (-- gone --)
lgtm
5 years ago (2015-12-16 00:51:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532463002/1
5 years ago (2015-12-16 00:52:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 00:57:13 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-16 00:58:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/005afed80274bf93a2ddc853c64baf3875367e7b
Cr-Commit-Position: refs/heads/master@{#365409}

Powered by Google App Engine
This is Rietveld 408576698