[turbofan] Support inline receiver allocation for class constructors.

[turbofan] Support inline receiver allocation for class constructors.

There's actually no need to restrict the inline allocation of
receivers for class constructors anymore; the relevant issues
were addressed in the compiler and runtime several weeks ago.

R=yangguo@chromium.org

Committed: https://chromium.googlesource.com/v8/v8/+/d0cfc9bfb8caa31aef1718df892f525ac1cc6863

[Benedikt Meurer, 2015-12-16 19:50:54]

bmeurer@chromium.org changed reviewers:
+ jarin@chromium.org

[Benedikt Meurer, 2015-12-16 19:50:54]

Hey Jaro,

An easy one, removing an obsolete restriction from the first inlining attempt.
Please take a look.

Thanks,
Benedikt

[Toon Verwaest, 2015-12-16 20:00:46]

verwaest@chromium.org changed reviewers:
+ verwaest@chromium.org

[Toon Verwaest, 2015-12-16 20:00:47]

I don't have that much context; but a quick question though.

https://codereview.chromium.org/1532453004/diff/1/src/compiler/js-typed-lower...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/1532453004/diff/1/src/compiler/js-typed-lower...
src/compiler/js-typed-lowering.cc:1416: // are limited anyways by the runtime).
DBC: Don't you only want to allow it for base classes with new.target == base?
We also store initial maps on subclasses, but the base class needs to get the
map from the new.target and verify it.

[Toon Verwaest, 2015-12-16 20:02:28]

Nevermind, I see this is for the case that target == new.target.

[Benedikt Meurer, 2015-12-16 20:29:07]

https://codereview.chromium.org/1532453004/diff/1/src/compiler/js-typed-lower...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/1532453004/diff/1/src/compiler/js-typed-lower...
src/compiler/js-typed-lowering.cc:1416: // are limited anyways by the runtime).
You already answered the question. I'm currently working on supporting
new.target here as well (essentially the case where target != new_target on the
Node* level), but I first had/still need to tweak some other parts of TurboFan
and the way we compile super calls to be able to actually trigger this case at
all.

[Yang, 2015-12-17 05:18:56]

yangguo@chromium.org changed reviewers:
+ yangguo@chromium.org

[Yang, 2015-12-17 05:18:56]

lgtm

[Benedikt Meurer, 2015-12-17 05:19:09]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-12-17 05:31:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1532453004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1532453004/1

[Benedikt Meurer, 2015-12-17 05:44:11]

The CQ bit was unchecked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-12-17 05:46:40]

Description was changed from

==========
[turbofan] Support inline receiver allocation for class constructors.

There's actually no need to restrict the inline allocation of
receivers for class constructors anymore; the relevant issues
were addressed in the compiler and runtime several weeks ago.
==========

to

==========
[turbofan] Support inline receiver allocation for class constructors.

There's actually no need to restrict the inline allocation of
receivers for class constructors anymore; the relevant issues
were addressed in the compiler and runtime several weeks ago.

R=yangguo@chromium.org

Committed: https://crrev.com/d0cfc9bfb8caa31aef1718df892f525ac1cc6863
Cr-Commit-Position: refs/heads/master@{#32925}
==========

[commit-bot: I haz the power, 2015-12-17 05:46:41]

Patchset 1 (id:??) landed as
https://crrev.com/d0cfc9bfb8caa31aef1718df892f525ac1cc6863
Cr-Commit-Position: refs/heads/master@{#32925}

[Benedikt Meurer, 2015-12-17 05:46:44]

Description was changed from

==========
[turbofan] Support inline receiver allocation for class constructors.

There's actually no need to restrict the inline allocation of
receivers for class constructors anymore; the relevant issues
were addressed in the compiler and runtime several weeks ago.

R=yangguo@chromium.org

Committed: https://crrev.com/d0cfc9bfb8caa31aef1718df892f525ac1cc6863
Cr-Commit-Position: refs/heads/master@{#32925}
==========

to

==========
[turbofan] Support inline receiver allocation for class constructors.

There's actually no need to restrict the inline allocation of
receivers for class constructors anymore; the relevant issues
were addressed in the compiler and runtime several weeks ago.

R=yangguo@chromium.org

Committed:
https://chromium.googlesource.com/v8/v8/+/d0cfc9bfb8caa31aef1718df892f525ac1c...
==========

[Benedikt Meurer, 2015-12-17 05:46:46]

Committed patchset #1 (id:1) manually as
d0cfc9bfb8caa31aef1718df892f525ac1cc6863 (presubmit successful).