Run all the tests in DomDistillerJsTest.RunJsTests

Run all the tests in DomDistillerJsTest.RunJsTests

innerHTML with empty attributes no longer breaks querySelectorAll on
ASan builds.

BUG=471854
Committed: https://crrev.com/d3d4d3448a0eee6a4ec06df45410ddbac31b04f6
Cr-Commit-Position: refs/heads/master@{#365421}

[wychen, 2015-12-16 00:07:05]

wychen@chromium.org changed reviewers:
+ mdjones@chromium.org, nyquist@chromium.org

[wychen, 2015-12-16 00:07:05]

PTAL.
Tommy, do you remember why we disabled these tests?

[mdjones, 2015-12-16 00:22:39]

https://codereview.chromium.org/1532453002/diff/1/components/dom_distiller/co...
File
components/dom_distiller/content/browser/test/dom_distiller_js_browsertest.cc
(right):

https://codereview.chromium.org/1532453002/diff/1/components/dom_distiller/co...
components/dom_distiller/content/browser/test/dom_distiller_js_browsertest.cc:51:
// TODO(wychen) Remove filter when crbug.com/471854 is fixed.
Remove todo?

https://codereview.chromium.org/1532453002/diff/1/components/dom_distiller/co...
components/dom_distiller/content/browser/test/dom_distiller_js_browsertest.cc:53:
"/war/test.html?console_log=0";
I think this fits on the line above.

[wychen, 2015-12-16 00:34:06]

Description was changed from

==========
Run all the tests in DomDistillerJsTest.RunJsTests

There is no reason to filter out some of these tests.

BUG=None
==========

to

==========
Run all the tests in DomDistillerJsTest.RunJsTests

innerHTML with empty attributes no longer breaks querySelectorAll
on ASan builds.

BUG=471854
==========

[wychen, 2015-12-16 00:52:18]

Description was changed from

==========
Run all the tests in DomDistillerJsTest.RunJsTests

innerHTML with empty attributes no longer breaks querySelectorAll
on ASan builds.

BUG=471854
==========

to

==========
Run all the tests in DomDistillerJsTest.RunJsTests

innerHTML with empty attributes no longer breaks querySelectorAll on
ASan builds.

BUG=471854
==========

[wychen, 2015-12-16 00:54:00]

https://codereview.chromium.org/1532453002/diff/1/components/dom_distiller/co...
File
components/dom_distiller/content/browser/test/dom_distiller_js_browsertest.cc
(right):

https://codereview.chromium.org/1532453002/diff/1/components/dom_distiller/co...
components/dom_distiller/content/browser/test/dom_distiller_js_browsertest.cc:51:
// TODO(wychen) Remove filter when crbug.com/471854 is fixed.
On 2015/12/16 00:22:38, mdjones wrote:
> Remove todo?

Done.

https://codereview.chromium.org/1532453002/diff/1/components/dom_distiller/co...
components/dom_distiller/content/browser/test/dom_distiller_js_browsertest.cc:53:
"/war/test.html?console_log=0";
On 2015/12/16 00:22:39, mdjones wrote:
> I think this fits on the line above.

Done.

[nyquist, 2015-12-16 01:11:12]

lgtm

[wychen, 2015-12-16 01:12:12]

The CQ bit was checked by wychen@chromium.org

[commit-bot: I haz the power, 2015-12-16 01:17:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1532453002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1532453002/20001

[commit-bot: I haz the power, 2015-12-16 03:39:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-16 03:41:11]

Description was changed from

==========
Run all the tests in DomDistillerJsTest.RunJsTests

innerHTML with empty attributes no longer breaks querySelectorAll on
ASan builds.

BUG=471854
==========

to

==========
Run all the tests in DomDistillerJsTest.RunJsTests

innerHTML with empty attributes no longer breaks querySelectorAll on
ASan builds.

BUG=471854

Committed: https://crrev.com/d3d4d3448a0eee6a4ec06df45410ddbac31b04f6
Cr-Commit-Position: refs/heads/master@{#365421}
==========

[commit-bot: I haz the power, 2015-12-16 03:41:11]

Patchset 2 (id:??) landed as
https://crrev.com/d3d4d3448a0eee6a4ec06df45410ddbac31b04f6
Cr-Commit-Position: refs/heads/master@{#365421}