Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: content/public/common/sandboxed_process_launcher_delegate.h

Issue 1532423003: Have each SandboxedProcessLauncherDelegate maintain a zygote. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanups per review., Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/sandboxed_process_launcher_delegate.h
diff --git a/content/public/common/sandboxed_process_launcher_delegate.h b/content/public/common/sandboxed_process_launcher_delegate.h
index a3aa4e06426534344883bdab2be7fe60536a296d..3bc86b78e0aef130d30b4decfdc57c60f32559ca 100644
--- a/content/public/common/sandboxed_process_launcher_delegate.h
+++ b/content/public/common/sandboxed_process_launcher_delegate.h
@@ -5,12 +5,15 @@
#ifndef CONTENT_PUBLIC_COMMON_SANDBOXED_PROCESS_LAUNCHER_DELEGATE_H_
#define CONTENT_PUBLIC_COMMON_SANDBOXED_PROCESS_LAUNCHER_DELEGATE_H_
+#include <cstddef>
+
#include "base/environment.h"
#include "base/files/scoped_file.h"
#include "base/process/process.h"
#include "build/build_config.h"
#include "content/common/content_export.h"
#include "content/public/common/sandbox_type.h"
+#include "content/public/common/zygote_alias.h"
namespace base {
class FilePath;
@@ -51,8 +54,10 @@ class CONTENT_EXPORT SandboxedProcessLauncherDelegate {
virtual void PostSpawnTarget(base::ProcessHandle process) {}
#elif defined(OS_POSIX)
+#if !defined(OS_MACOSX) && !defined(OS_ANDROID)
// Override this to return true to use the setuid sandbox.
- virtual bool ShouldUseZygote();
+ virtual ZygoteHandle* GetZygote();
+#endif // !defined(OS_MACOSX) && !defined(OS_ANDROID)
// Override this if the process needs a non-empty environment map.
virtual base::EnvironmentMap GetEnvironment();

Powered by Google App Engine
This is Rietveld 408576698