Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: components/nacl/browser/nacl_process_host.cc

Issue 1532423003: Have each SandboxedProcessLauncherDelegate maintain a zygote. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix IWYU errors Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/about_ui.cc ('k') | content/browser/child_process_launcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/browser/nacl_process_host.cc
diff --git a/components/nacl/browser/nacl_process_host.cc b/components/nacl/browser/nacl_process_host.cc
index 41e337a408bb0fd76fb89ad7381449f100fd71f6..75ab51ca52ebe7a0b7e01a3d7f49782ffe5aeefe 100644
--- a/components/nacl/browser/nacl_process_host.cc
+++ b/components/nacl/browser/nacl_process_host.cc
@@ -181,7 +181,13 @@ class NaClSandboxedProcessLauncherDelegate
}
}
#elif defined(OS_POSIX)
- bool ShouldUseZygote() override { return true; }
+#if !defined(OS_MACOSX) && !defined(OS_ANDROID)
+ content::ZygoteHandle* GetZygote() override {
+ static content::ZygoteHandle zygote;
Mark Seaborn 2016/01/11 22:42:39 Does this mean the zygote process is launched on d
mdempsky 2016/01/11 22:50:28 Yes. I'm not convinced that's a problem per se (s
+ return &zygote;
+ }
+#endif // !defined(OS_MACOSX) && !defined(OS_ANDROID)
+
base::ScopedFD TakeIpcFd() override { return std::move(ipc_fd_); }
#endif // OS_WIN
« no previous file with comments | « chrome/browser/ui/webui/about_ui.cc ('k') | content/browser/child_process_launcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698