Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1532323002: Remove unused constant kInvalidFrameRoutingID (Closed)

Created:
5 years ago by davve
Modified:
4 years, 11 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused constant kInvalidFrameRoutingID All use of kInvalidFrameRoutingID was removed in https://codereview.chromium.org/1138543002 but for the constant. Committed: https://crrev.com/443a79161db949aa4049aef6baa6dffcfdd32567 Cr-Commit-Position: refs/heads/master@{#367287}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/renderer/history_entry.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532323002/1
5 years ago (2015-12-18 09:34:40 UTC) #2
davve
Something I just happened to stumble upon. PTAL at your leisure.
5 years ago (2015-12-18 09:35:07 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-18 10:42:12 UTC) #6
Nate Chapin
lgtm, but I'm not an OWNER
4 years, 11 months ago (2015-12-30 23:14:27 UTC) #7
Avi (use Gerrit)
lgtm I am an owner.
4 years, 11 months ago (2015-12-30 23:20:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532323002/1
4 years, 11 months ago (2016-01-03 10:32:28 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-03 13:24:47 UTC) #12
commit-bot: I haz the power
Failed to apply the patch.
4 years, 11 months ago (2016-01-03 13:25:05 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-03 13:26:02 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/443a79161db949aa4049aef6baa6dffcfdd32567
Cr-Commit-Position: refs/heads/master@{#367287}

Powered by Google App Engine
This is Rietveld 408576698