Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1532303002: Merge to XFA: Correctly extracting email addresses (Closed)

Created:
5 years ago by Wei Li
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Correctly extracting email addresses An email address contains user name part and host name part. User name allows dash or underscore, but not leading/ending/double period. Host name doesn't allow leading/ending/double period either. BUG=489107 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1530763005 . (cherry picked from commit cc70b7b55c9edcd0ff038f59080699060fbbede1) Committed: https://pdfium.googlesource.com/pdfium/+/60eac0f7cebd682e93eb5d8a0950f31856099081

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -50 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M core/include/fxcrt/fx_ext.h View 1 chunk +9 lines, -0 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 2 chunks +39 lines, -49 lines 0 comments Download
A core/src/fpdftext/fpdf_text_int_unittest.cpp View 1 chunk +56 lines, -0 lines 0 comments Download
M core/src/fpdftext/text_int.h View 1 chunk +1 line, -1 line 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Wei Li
Clean merge, TBR
5 years ago (2015-12-18 02:16:02 UTC) #1
Wei Li
Committed patchset #1 (id:1) manually as 60eac0f7cebd682e93eb5d8a0950f31856099081 (presubmit successful).
5 years ago (2015-12-18 02:16:29 UTC) #3
Lei Zhang
5 years ago (2015-12-18 05:40:56 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698