Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1532243002: Revert of Use the new Mojo EDK in chrome. (Closed)

Created:
5 years ago by jam
Modified:
5 years ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use the new Mojo EDK in chrome. (patchset #3 id:180001 of https://codereview.chromium.org/1511023006/ ) Reason for revert: Reverting because there are leaks in unit tests. I'll fix those and reland. Original issue's description: > Use the new Mojo EDK in chrome. > > --use-old-edk can override this temporarily. > > BUG=561803 > > Committed: https://crrev.com/710285b713a25f10f641e0d530c77cc3e4151df7 > Cr-Commit-Position: refs/heads/master@{#364599} > > Committed: https://crrev.com/9c86764dba8f7c16f2229b4f8fdb544f3da97582 > Cr-Commit-Position: refs/heads/master@{#365887} TBR=sky@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=561803 Committed: https://crrev.com/c388666f803ed40f8c3bb4532b42e9c378db0b4a Cr-Commit-Position: refs/heads/master@{#365941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/app/mojo/mojo_init.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
jam
Created Revert of Use the new Mojo EDK in chrome.
5 years ago (2015-12-17 23:45:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532243002/1
5 years ago (2015-12-17 23:47:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 23:49:50 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-17 23:50:36 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c388666f803ed40f8c3bb4532b42e9c378db0b4a
Cr-Commit-Position: refs/heads/master@{#365941}

Powered by Google App Engine
This is Rietveld 408576698