webkit/common/webkit_common.gyp - Issue 153223002: Use gyp targets to link in X11 libraries instead of setting -lXfoo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/common/webkit_common.gyp

Issue 153223002: Use gyp targets to link in X11 libraries instead of setting -lXfoo (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address feedback, try to fix cros_x86 gyp error Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/common/webkit_common.gyp

diff --git a/webkit/common/webkit_common.gyp b/webkit/common/webkit_common.gyp

index 3de9cffb1b01dc91f484de275250831f8110a791..33eec7ca4e8bdc6ce072a0024b0da63d3b8791f2 100644

--- a/webkit/common/webkit_common.gyp

+++ b/webkit/common/webkit_common.gyp

@@ -75,9 +75,9 @@

}],

['use_aura==1 and use_x11==1', {

- 'link_settings': {

- 'libraries': [ '-lXcursor', ],

- },

+ 'dependencies': [

+ '<(DEPTH)/build/linux/system.gyp:xcursor',

+ ],

}],

['use_ozone==0', {

'sources!': [

« no previous file with comments | « ui/views/views.gyp ('k') | no next file » | no next file with comments »