Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: ui/ui.gyp

Issue 153223002: Use gyp targets to link in X11 libraries instead of setting -lXfoo (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address feedback, try to fix cros_x86 gyp error Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gl/gl.gyp ('k') | ui/views/views.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/ui.gyp
diff --git a/ui/ui.gyp b/ui/ui.gyp
index 28148e396387adbdb507251519faf824d1e84e37..e731809d341d1d81876247dc3d712411b9f307af 100644
--- a/ui/ui.gyp
+++ b/ui/ui.gyp
@@ -527,25 +527,23 @@
'ldflags': [
'-L<(PRODUCT_DIR)',
],
+ # TODO(jamesr): Targets using X11 should declare dependencies on the
+ # appropriate build/linux/system.gyp targets themselves instead of
+ # independently picking it up from ui.
'link_settings': {
'libraries': [
'-lX11',
'-lXcursor',
- '-lXrender', # For XRender* function calls in x11_util.cc.
+ '-lXrender',
],
},
},
- 'link_settings': {
- 'libraries': [
- '-lX11',
- '-lXcursor',
- '-lXrender', # For XRender* function calls in x11_util.cc.
- ],
- },
'dependencies': [
'../build/linux/system.gyp:x11',
+ '../build/linux/system.gyp:xcursor',
'../build/linux/system.gyp:xext',
'../build/linux/system.gyp:xfixes',
+ '../build/linux/system.gyp:xrender', # For XRender* function calls in x11_util.cc.
],
}],
['use_ozone==0', {
« no previous file with comments | « ui/gl/gl.gyp ('k') | ui/views/views.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698