media/cast/cast.gyp - Issue 153223002: Use gyp targets to link in X11 libraries instead of setting -lXfoo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/cast.gyp

Issue 153223002: Use gyp targets to link in X11 libraries instead of setting -lXfoo (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address feedback, try to fix cros_x86 gyp error Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/cast/cast.gyp

diff --git a/media/cast/cast.gyp b/media/cast/cast.gyp

index 16df8a66f3b92ea8255ce4b5a851f723507ba374..ac90b7c0c54ba9fd31a2056d1897e7fd4a674f5b 100644

--- a/media/cast/cast.gyp

+++ b/media/cast/cast.gyp

@@ -146,14 +146,14 @@

'conditions': [

['OS == "linux"', {

+ 'dependencies': [

+ '<(DEPTH)/build/linux/system.gyp:x11',

+ '<(DEPTH)/build/linux/system.gyp:xext',

+ ],

'sources': [

'<(DEPTH)/media/cast/test/linux_output_window.cc',

'<(DEPTH)/media/cast/test/linux_output_window.h',

- 'libraries': [

- '-lXext',

- '-lX11',

- ],

}],

« no previous file with comments | « content/content_plugin.gypi ('k') | media/media.gyp » ('j') | no next file with comments »