chrome/chrome_common.gypi - Issue 153223002: Use gyp targets to link in X11 libraries instead of setting -lXfoo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_common.gypi

Issue 153223002: Use gyp targets to link in X11 libraries instead of setting -lXfoo (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address feedback, try to fix cros_x86 gyp error Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_common.gypi

diff --git a/chrome/chrome_common.gypi b/chrome/chrome_common.gypi

index 773a7decf290170fc5ba626e8bde5e1972e98edc..b0a015e9ca677682ad933105d144bb0e0bb19f44 100644

--- a/chrome/chrome_common.gypi

+++ b/chrome/chrome_common.gypi

@@ -495,16 +495,16 @@

['toolkit_uses_gtk == 1', {

'dependencies': [

'../build/linux/system.gyp:gtk',

+ '../build/linux/system.gyp:x11',

+ '../build/linux/system.gyp:xrender',

+ '../build/linux/system.gyp:xext',

'export_dependent_settings': [

'../third_party/sqlite/sqlite.gyp:sqlite',

'link_settings': {

'libraries': [

- '-lX11',

- '-lXrender',

'-lXss',

- '-lXext',

}],

« no previous file with comments | « build/linux/system.gyp ('k') | chromeos/chromeos.gyp » ('j') | no next file with comments »