Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 1532223005: Remove trust from any certs in ScopedTestDB before closing it. (Closed)

Created:
5 years ago by mattm
Modified:
4 years, 12 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove trust from any certs in ScopedTestDB before closing it. Otherwise NSS may cache verification results even after the test DB is gone. BUG=569657 TEST=net_unittests --gtest_filter='CertDatabaseNSSTest.ImportCaAndServerCert:TestRootCertsTest.OverrideTrust' --gtest_shuffle --gtest_repeat=25 Committed: https://crrev.com/b3dfdd83b1cf55b787433c6ad6bcca97269b528f Cr-Commit-Position: refs/heads/master@{#367016}

Patch Set 1 : . #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M crypto/scoped_test_nss_db.cc View 1 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mattm
Didn't see any (related) problems running net_unittests under tsan.
5 years ago (2015-12-19 01:46:53 UTC) #3
Ryan Sleevi
LGTM. It just means we can't use both a 'test' and the real trust DB ...
4 years, 12 months ago (2015-12-28 21:25:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532223005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532223005/40001
4 years, 12 months ago (2015-12-28 21:45:31 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 12 months ago (2015-12-28 22:18:30 UTC) #7
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 22:19:26 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b3dfdd83b1cf55b787433c6ad6bcca97269b528f
Cr-Commit-Position: refs/heads/master@{#367016}

Powered by Google App Engine
This is Rietveld 408576698