Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1532203002: Update README.chromium to reflect whether a tool is shipped or not (Closed)

Created:
5 years ago by hichris123
Modified:
4 years, 11 months ago
CC:
Paweł Hajdan Jr., chromium-reviews, samuong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update README.chromium to reflect whether a tool is shipped or not Mark tools that are only used for testing as NOT_SHIPPED. Also fix bintree's license (MIT License -> MIT) and fix the name & short name of libc++-static. BUG=499582 Committed: https://crrev.com/6175da8042f3a0aa574f0da25e87be342625e603 Cr-Commit-Position: refs/heads/master@{#369150}

Patch Set 1 #

Patch Set 2 : Add two more #

Patch Set 3 : Add webdriver #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -14 lines) Patch
M chrome/test/chromedriver/third_party/googlecode/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/third_party/mock4js/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/build_tools/sdk_tools/third_party/fancy_urllib/README.chromium View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/third_party/pthreads-win32/README.chromium View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/bintrees/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/checkstyle/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/codesighs/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/colorama/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/devscripts/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libc++-static/README.chromium View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/py_trace_event/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/pycoverage/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/pyftpdlib/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/pymock/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/pywebsocket/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/webdriver/README.chromium View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/webtreemap/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M tools/licenses.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
hichris123
Hi - PTAL: jochen: chrome/ & third_party/ Pawel: tools/licenses.py Brad: native_client_sdk/ Should be relatively straightforward ...
5 years ago (2015-12-18 00:28:04 UTC) #4
jochen (gone - plz use gerrit)
Lei, you've filed the bug, would you mind to review this CL?
5 years ago (2015-12-18 08:05:43 UTC) #6
Lei Zhang
lgtm
5 years ago (2015-12-18 08:53:38 UTC) #7
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-12-18 08:56:17 UTC) #8
bradnelson
lgtm
5 years ago (2015-12-18 10:39:46 UTC) #9
hichris123
Bumping this as it probably got buried in Pawel's inbox.
4 years, 11 months ago (2016-01-12 21:32:17 UTC) #10
Paweł Hajdan Jr.
LGTM
4 years, 11 months ago (2016-01-13 08:53:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532203002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532203002/40001
4 years, 11 months ago (2016-01-13 11:48:43 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-13 12:37:38 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 12:38:29 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6175da8042f3a0aa574f0da25e87be342625e603
Cr-Commit-Position: refs/heads/master@{#369150}

Powered by Google App Engine
This is Rietveld 408576698