sync: Count nodes more efficiently

sync/internal_api/base_node.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/internal_api/public/base_node.h"
 
 #include <stack>
 
 #include "base/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
@@ skipping 198 matching lines @@
 }
 
 int64 BaseNode::GetFirstChildId() const {
   syncable::Id id_string = GetEntry()->GetFirstChildId();
   if (id_string.IsRoot())
     return kInvalidId;
   return IdToMetahandle(GetTransaction()->GetWrappedTrans(), id_string);
 }
 
 int BaseNode::GetTotalNodeCount() const {
-  syncable::BaseTransaction* trans = GetTransaction()->GetWrappedTrans();
-
-  int count = 1;  // Start with one to include the node itself.
-
-  std::stack<int64> stack;
-  stack.push(GetFirstChildId());
-  while (!stack.empty()) {
-    int64 handle = stack.top();
-    stack.pop();
-    if (handle == kInvalidId)
-      continue;
-    count++;
-    syncable::Entry entry(trans, syncable::GET_BY_HANDLE, handle);
-    if (!entry.good())
-      continue;
-    syncable::Id successor_id = entry.GetSuccessorId();
-    if (!successor_id.IsRoot())
-      stack.push(IdToMetahandle(trans, successor_id));
-    if (!entry.Get(syncable::IS_DIR))
-      continue;
-    syncable::Id child_id = entry.GetFirstChildId();
-    if (!child_id.IsRoot())
-      stack.push(IdToMetahandle(trans, child_id));
-  }
-  return count;
+  return GetEntry()->GetTotalNodeCount();
 }
 
 DictionaryValue* BaseNode::GetSummaryAsValue() const {
   DictionaryValue* node_info = new DictionaryValue();
   node_info->SetString("id", base::Int64ToString(GetId()));
   node_info->SetBoolean("isFolder", GetIsFolder());
   node_info->SetString("title", GetTitle());
   node_info->Set("type", ModelTypeToValue(GetModelType()));
   return node_info;
 }
@@ skipping 114 matching lines @@
     const sync_pb::EntitySpecifics& specifics) {
   ModelType type = GetModelTypeFromSpecifics(specifics);
   DCHECK_NE(UNSPECIFIED, type);
   if (GetModelType() != UNSPECIFIED) {
     DCHECK_EQ(GetModelType(), type);
   }
   unencrypted_data_.CopyFrom(specifics);
 }
 
 }  // namespace syncer