Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1532183002: EDK: Split embedder.* into embedder.* and multiprocess_embedder.*. (Closed)

Created:
5 years ago by viettrungluu
Modified:
5 years ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Split embedder.* into embedder.* and multiprocess_embedder.*. The goal is to (eventually) have two targets: a small single-process-only EDK target (with very few dependencies) and a bigger multiprocess one. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/cf436be0a6b56714962abdb78dc51c71ed68d585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1285 lines) Patch
M mojo/edk/embedder/BUILD.gn View 3 chunks +5 lines, -0 lines 0 comments Download
M mojo/edk/embedder/embedder.h View 2 chunks +1 line, -178 lines 0 comments Download
M mojo/edk/embedder/embedder.cc View 3 chunks +1 line, -226 lines 0 comments Download
M mojo/edk/embedder/embedder_unittest.cc View 3 chunks +2 lines, -661 lines 0 comments Download
A + mojo/edk/embedder/multiprocess_embedder.h View 3 chunks +4 lines, -49 lines 0 comments Download
A + mojo/edk/embedder/multiprocess_embedder.cc View 4 chunks +2 lines, -66 lines 0 comments Download
A + mojo/edk/embedder/multiprocess_embedder_unittest.cc View 9 chunks +13 lines, -103 lines 0 comments Download
M mojo/edk/test/scoped_ipc_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M shell/child_main.cc View 1 chunk +1 line, -0 lines 0 comments Download
M shell/child_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M shell/context.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
5 years ago (2015-12-18 00:28:50 UTC) #1
vardhan
On 2015/12/18 00:28:50, viettrungluu wrote: LGTM
5 years ago (2015-12-18 18:18:03 UTC) #2
viettrungluu
5 years ago (2015-12-18 19:02:04 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
cf436be0a6b56714962abdb78dc51c71ed68d585 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698