Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1532163002: Copy vcruntime*.dll to the build directory for the VS2015 builds. (Closed)

Created:
5 years ago by Sébastien Marchand
Modified:
5 years ago
Reviewers:
scottmg, brucedawson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Copy vcruntime*.dll to the build directory for the VS2015 builds. It looks like it's needed at least for the PGI instrumented builds (my guess is that pgort140.dll has a dependency on this). R=scottmg@chromium.org BUG=440500 Committed: https://crrev.com/7cebe2199a4ed5b97f00369b54788216e7f399d6 Cr-Commit-Position: refs/heads/master@{#365875}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/vs_toolchain.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Sébastien Marchand
PTAL.
5 years ago (2015-12-17 19:19:13 UTC) #1
scottmg
lgtm fyi +bruce
5 years ago (2015-12-17 19:42:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532163002/1
5 years ago (2015-12-17 19:49:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 20:44:43 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-17 20:45:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7cebe2199a4ed5b97f00369b54788216e7f399d6
Cr-Commit-Position: refs/heads/master@{#365875}

Powered by Google App Engine
This is Rietveld 408576698