components/nacl/browser/nacl_file_host.cc - Issue 1532053002: use variadic macros/templates in IPC message implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/browser/nacl_file_host.cc

Issue 1532053002: use variadic macros/templates in IPC message implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: stricter legacy compat macros Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/nacl/browser/nacl_file_host.cc

diff --git a/components/nacl/browser/nacl_file_host.cc b/components/nacl/browser/nacl_file_host.cc

index 0c10254f16302593b859f938ad12fbe4b0c06501..36c9eba66fbfb0017593906cd1f9361db19805bb 100644

--- a/components/nacl/browser/nacl_file_host.cc

+++ b/components/nacl/browser/nacl_file_host.cc

@@ -43,9 +43,9 @@ void NotifyRendererOfError(

}

typedef void (*WriteFileInfoReply)(IPC::Message* reply_msg,

- IPC::PlatformFileForTransit file_desc,

- uint64_t file_token_lo,

- uint64_t file_token_hi);

+ const IPC::PlatformFileForTransit& file_desc,

+ const uint64_t& file_token_lo,

dcheng 2016/02/05 21:31:41 Why change these to const ref?

mdempsky 2016/02/05 22:36:06 See https://codereview.chromium.org/1532053002/dif

+ const uint64_t& file_token_hi);

void DoRegisterOpenedNaClExecutableFile(

scoped_refptr<nacl::NaClHostMessageFilter> nacl_host_message_filter,

« no previous file with comments | « base/export_template.h ('k') | content/renderer/input/input_event_filter.cc » ('j') | ipc/ipc_message_macros.h » ('J')