Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1005)

Side by Side Diff: components/nacl/browser/nacl_file_host.cc

Issue 1532053002: use variadic macros/templates in IPC message implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move for real Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/renderer/input/input_event_filter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/nacl/browser/nacl_file_host.h" 5 #include "components/nacl/browser/nacl_file_host.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 25 matching lines...) Expand all
36 const size_t kMaxFileLength = 40; 36 const size_t kMaxFileLength = 40;
37 37
38 void NotifyRendererOfError( 38 void NotifyRendererOfError(
39 nacl::NaClHostMessageFilter* nacl_host_message_filter, 39 nacl::NaClHostMessageFilter* nacl_host_message_filter,
40 IPC::Message* reply_msg) { 40 IPC::Message* reply_msg) {
41 reply_msg->set_reply_error(); 41 reply_msg->set_reply_error();
42 nacl_host_message_filter->Send(reply_msg); 42 nacl_host_message_filter->Send(reply_msg);
43 } 43 }
44 44
45 typedef void (*WriteFileInfoReply)(IPC::Message* reply_msg, 45 typedef void (*WriteFileInfoReply)(IPC::Message* reply_msg,
46 IPC::PlatformFileForTransit file_desc, 46 const IPC::PlatformFileForTransit& file_desc,
47 uint64_t file_token_lo, 47 const uint64_t& file_token_lo,
48 uint64_t file_token_hi); 48 const uint64_t& file_token_hi);
49 49
50 void DoRegisterOpenedNaClExecutableFile( 50 void DoRegisterOpenedNaClExecutableFile(
51 scoped_refptr<nacl::NaClHostMessageFilter> nacl_host_message_filter, 51 scoped_refptr<nacl::NaClHostMessageFilter> nacl_host_message_filter,
52 base::File file, 52 base::File file,
53 base::FilePath file_path, 53 base::FilePath file_path,
54 IPC::Message* reply_msg, 54 IPC::Message* reply_msg,
55 WriteFileInfoReply write_reply_message) { 55 WriteFileInfoReply write_reply_message) {
56 // IO thread owns the NaClBrowser singleton. 56 // IO thread owns the NaClBrowser singleton.
57 DCHECK_CURRENTLY_ON(BrowserThread::IO); 57 DCHECK_CURRENTLY_ON(BrowserThread::IO);
58 58
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
272 &DoOpenNaClExecutableOnThreadPool, 272 &DoOpenNaClExecutableOnThreadPool,
273 nacl_host_message_filter, 273 nacl_host_message_filter,
274 file_url, 274 file_url,
275 enable_validation_caching, 275 enable_validation_caching,
276 reply_msg))) { 276 reply_msg))) {
277 NotifyRendererOfError(nacl_host_message_filter.get(), reply_msg); 277 NotifyRendererOfError(nacl_host_message_filter.get(), reply_msg);
278 } 278 }
279 } 279 }
280 280
281 } // namespace nacl_file_host 281 } // namespace nacl_file_host
OLDNEW
« no previous file with comments | « no previous file | content/renderer/input/input_event_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698