use variadic macros/templates in IPC message implementation

content/renderer/render_thread_impl_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/location.h"
 #include "base/memory/discardable_memory.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/thread_task_runner_handle.h"
 #include "components/scheduler/renderer/renderer_scheduler.h"
 #include "content/app/mojo/mojo_init.h"
 #include "content/common/in_process_child_thread_params.h"
 #include "content/common/resource_messages.h"
 #include "content/common/websocket_messages.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/renderer/content_renderer_client.h"
 #include "content/renderer/render_process_impl.h"
 #include "content/renderer/render_thread_impl.h"
 #include "content/test/mock_render_process.h"
 #include "content/test/render_thread_impl_browser_test_ipc_helper.h"
 #include "gpu/GLES2/gl2extchromium.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 // IPC messages for testing ----------------------------------------------------
 
+// TODO(mdempsky): Fix properly.

[danakj, 2015/12/19 00:15:05]

Can you leave more context, what is properly?

[mdempsky, 2015/12/19 02:14:48]

"Properly" here is creating browsertest_messages.h and
browsertest_messages_generator.cc and doing the full #include ritual like in
content/common/content_message_generator.cc.

The problem here is that ipc/ipc_messages_macro.h has already been #include'd by
the FOO_messages.h headers included above, so defining IPC_MESSAGE_IMPL here
wasn't doing anything.  It happened to work only because it's only used for
TestMsg_QuitRunLoop, which is a 0-argument async message, and the macros before
happened to implement enough of those even without IPC_MESSAGE_IMPL for this
file to work.

+#undef IPC_IPC_MESSAGE_MACROS_H_
+#undef IPC_MESSAGE_EXTRA
 #define IPC_MESSAGE_IMPL
 #include "ipc/ipc_message_macros.h"
+#include "ipc/ipc_message_templates_impl.h"
 
 #undef IPC_MESSAGE_START
 #define IPC_MESSAGE_START TestMsgStart
 IPC_MESSAGE_CONTROL0(TestMsg_QuitRunLoop)
 
 // -----------------------------------------------------------------------------
 
 // These tests leak memory, this macro disables the test when under the
 // LeakSanitizer.
 #ifdef LEAK_SANITIZER
@@ skipping 190 matching lines @@
   test_helper_->Sender()->Send(new WebSocketMsg_NotifyFailure(1, ""));
   test_helper_->Sender()->Send(new TestMsg_QuitRunLoop());
 
   test_helper_->GetMessageLoop()->Run();
 
   EXPECT_EQ(0, test_task_counter_->NumTasksPosted());
 }
 
 }  // namespace
 }  // namespace content