Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1531913002: Add UnlinkedClass.hasNoSupertype property to summaries. (Closed)

Created:
5 years ago by Paul Berry
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add UnlinkedClass.hasNoSupertype property to summaries. This is necessary in order to properly summarize the core type `Object`, which lacks a supertype. Note that there is no test for this functionality in resynthesize_test.dart. It will be covered as soon as the test `fail_core` is enabled. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/493a03a0edf6ad534fc957a3ca5597122f45fb2a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 6 chunks +14 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 3 chunks +4 lines, -0 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
5 years ago (2015-12-16 22:10:47 UTC) #2
Brian Wilkerson
LGTM
5 years ago (2015-12-16 22:30:27 UTC) #3
Paul Berry
5 years ago (2015-12-16 23:18:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
493a03a0edf6ad534fc957a3ca5597122f45fb2a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698