Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1531873004: base: remove dcheng's TODO for updating webrtc (Closed)

Created:
5 years ago by tfarina
Modified:
5 years ago
Reviewers:
danakj, dcheng
CC:
dcheng, chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: remove dcheng's TODO for updating webrtc I have updated webrtc in https://chromium.googlesource.com/external/webrtc/+/66679dcc04658e5e0dc334f53e647eb9eb3107ed BUG=None R=danakj@chromium.org Committed: https://crrev.com/ab8296e3e739f61ddc5d79a2286e10228b6aa704 Cr-Commit-Position: refs/heads/master@{#365882}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M base/compiler_specific.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
tfarina
Daniel, fyi.
5 years ago (2015-12-17 18:18:54 UTC) #1
danakj
Thanks LGTM
5 years ago (2015-12-17 20:15:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531873004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531873004/1
5 years ago (2015-12-17 20:23:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 20:57:29 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ab8296e3e739f61ddc5d79a2286e10228b6aa704 Cr-Commit-Position: refs/heads/master@{#365882}
5 years ago (2015-12-17 20:58:37 UTC) #7
dcheng
5 years ago (2015-12-17 20:59:52 UTC) #9
Message was sent while issue was closed.
Thanks for cleaning this up in webrtc! Sorry for not doing this myself...
committing to the webrtc repo is a pain.

Powered by Google App Engine
This is Rietveld 408576698