Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1531843003: Rename IS_SPEC_OBJECT macro to IS_RECEIVER. (Closed)

Created:
5 years ago by neis
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Rename IS_SPEC_OBJECT macro to IS_RECEIVER. And remove confusing comment. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/fe484ff648a452eca6ce47bf3a2d770d7993740c Cr-Commit-Position: refs/heads/master@{#32935}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -57 lines) Patch
M src/debug/mirrors.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/array.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/array-iterator.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/js/harmony-reflect.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/harmony-regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/json.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/js/macros.py View 1 chunk +4 lines, -9 lines 0 comments Download
M src/js/messages.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/js/object-observe.js View 6 chunks +7 lines, -7 lines 0 comments Download
M src/js/promise.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/js/proxy.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/string-iterator.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/v8natives.js View 9 chunks +15 lines, -15 lines 0 comments Download
M src/js/weak-collection.js View 8 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
neis
5 years ago (2015-12-17 08:09:14 UTC) #1
Benedikt Meurer
LGTM
5 years ago (2015-12-17 08:10:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531843003/1
5 years ago (2015-12-17 08:22:24 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/13226)
5 years ago (2015-12-17 08:43:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531843003/1
5 years ago (2015-12-17 09:24:44 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 09:43:41 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-17 09:44:11 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fe484ff648a452eca6ce47bf3a2d770d7993740c
Cr-Commit-Position: refs/heads/master@{#32935}

Powered by Google App Engine
This is Rietveld 408576698