Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1531833002: Remove Subset*Benches (Closed)

Created:
5 years ago by scroggo
Modified:
5 years ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove Subset*Benches These were originally used to compare to the old implementation of subset decoding in SkImageDecoder. The old implementation has been removed, and they do not provide useful information that is not covered by the BitmapRegionDecoderBenches. This will greatly speed up some of our infra bots, which spend a lot of time decoding interlaced PNGs repeatedly (thanks to SubsetTranslateBench). BUG=skia:4715 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1531833002 Committed: https://skia.googlesource.com/skia/+/789fd996599fc7fc29963ed2db9e4b7427973be9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -565 lines) Patch
M bench/nanobench.cpp View 5 chunks +0 lines, -113 lines 0 comments Download
D bench/subset/SubsetBenchPriv.h View 1 chunk +0 lines, -30 lines 0 comments Download
D bench/subset/SubsetSingleBench.h View 1 chunk +0 lines, -44 lines 0 comments Download
D bench/subset/SubsetSingleBench.cpp View 1 chunk +0 lines, -89 lines 0 comments Download
D bench/subset/SubsetTranslateBench.h View 1 chunk +0 lines, -40 lines 0 comments Download
D bench/subset/SubsetTranslateBench.cpp View 1 chunk +0 lines, -108 lines 0 comments Download
D bench/subset/SubsetZoomBench.h View 1 chunk +0 lines, -40 lines 0 comments Download
D bench/subset/SubsetZoomBench.cpp View 1 chunk +0 lines, -101 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
scroggo
5 years ago (2015-12-16 17:02:05 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531833002/1
5 years ago (2015-12-16 17:02:06 UTC) #5
msarett
lgtm
5 years ago (2015-12-16 17:03:38 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-16 17:15:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531833002/1
5 years ago (2015-12-16 18:20:56 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-16 18:21:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/789fd996599fc7fc29963ed2db9e4b7427973be9

Powered by Google App Engine
This is Rietveld 408576698