Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1531803002:
Add AdobeRGB1998 Munsell chart layout test (Closed)
|
Created:
5 years ago by Noel Gordon Modified:
5 years ago Reviewers:
Justin Novosad CC:
chromium-reviews, blink-reviews, radu.velea Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd AdobeRGB1998 Munsell chart layout test
Like the sRGB-to-sRGB Munsell chart test, but wider-gamut. Add a
Munsell chart AdobeRGB1998 to sRGB color transform test.
The test is designed to run in the test harness or manually, and
tabulates the dE (per color error from the expected Munsell sRGB
colors [1]) and total RMS color error.
Since a color transform is applied, this test may produce output
colors different from the expected colors, but the RMS error (or
score) is what matters. Scores below 2 (2 is the level of a Just
Noticeable Difference [JND]) are considered good, and good color
correction libraries score well below that on this test [2].
[1] For more details on Munsell colors and gamuts, see
http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html
[2] http://bit.ly/1Gkadze Adobe to sRGB chart tests, QCMS scores
less than 0.9 on this test. A similar test has been added to our
QCMS tests, issue 532910.
BUG=570317
Committed: https://crrev.com/41e148e07880590674f5eaf1ba8145da8938709a
Cr-Commit-Position: refs/heads/master@{#365715}
Relanding: with the layout test marked [ NeedsManualRebaseline ]
while the rebaseline server is being fixed, issue 570401.
BUG=570317
Committed: https://crrev.com/3a1a10ca2b50dfb459a5dc49036c2e6e9953fc6a
Cr-Commit-Position: refs/heads/master@{#366549}
Patch Set 1 #Patch Set 2 : Land with [ NeedsManualRebaseline ] #
Messages
Total messages: 26 (12 generated)
Description was changed from ========== Add AdobeRGB1998 Munsell chart layout test BUG=524919 ========== to ========== Add AdobeRGB1998 Munsell chart layout test Like the sRGB-to-sRGB Munsell chart test, but wider-gamut. Add a Munsell chart AdobeRGB1998 to sRGB color transform test. The test is designed to run in the test harness or manually, and tabulates the dE (per color error from the expected Munsell sRGB colors [1]) and the total RMS color error. Since a color transform is applied, this test may produce output colors different from those expected colors but the RMS error is what matters. Scores below 2 (2 is the level of a Just Noticable Difference, a JND) are considered good and good color correction libraries score well below that on this test [2]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html [2] http://bit.ly/1Gkadze Adobe to sRGB chart tests, QCMS scores less than 0.9 on this test. A similar test has been added to our QCMS tests, issue 532910. BUG=570317 ==========
noel@chromium.org changed reviewers: + junov@chromium.org
Last in this series (color chart accuracy tests).
Any my props to Radu for the SSE case RMS improvements on https://code.google.com/p/chromium/issues/detail?id=532910#c24
On 2015/12/16 16:20:24, noel gordon wrote: > Any my props to Radu for the SSE case RMS improvements on Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.87 (was 0.94)
lgtm
Description was changed from ========== Add AdobeRGB1998 Munsell chart layout test Like the sRGB-to-sRGB Munsell chart test, but wider-gamut. Add a Munsell chart AdobeRGB1998 to sRGB color transform test. The test is designed to run in the test harness or manually, and tabulates the dE (per color error from the expected Munsell sRGB colors [1]) and the total RMS color error. Since a color transform is applied, this test may produce output colors different from those expected colors but the RMS error is what matters. Scores below 2 (2 is the level of a Just Noticable Difference, a JND) are considered good and good color correction libraries score well below that on this test [2]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html [2] http://bit.ly/1Gkadze Adobe to sRGB chart tests, QCMS scores less than 0.9 on this test. A similar test has been added to our QCMS tests, issue 532910. BUG=570317 ========== to ========== Add AdobeRGB1998 Munsell chart layout test Like the sRGB-to-sRGB Munsell chart test, but wider-gamut. Add a Munsell chart AdobeRGB1998 to sRGB color transform test. The test is designed to run in the test harness or manually, and tabulates the dE (per color error from the expected Munsell sRGB colors [1]) and total RMS color error. Since a color transform is applied, this test may produce output colors different from the expected colors, but the RMS error (or score) is what matters. Scores below 2 (2 is the level of a Just Noticeable Difference [JND]) are considered good, and good color correction libraries score well below that on this test [2]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html [2] http://bit.ly/1Gkadze Adobe to sRGB chart tests, QCMS scores less than 0.9 on this test. A similar test has been added to our QCMS tests, issue 532910. BUG=570317 ==========
The CQ bit was checked by noel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531803002/1
"The RMS error (or score) is what matters". For example, ColorSync on OSX measured via the OSX Image Viewer scores well on this test, as does Safari. Their individual scores are different though, due to off-by-one pixel diffs for some colors.
QCMS software and SSE paths also show similar diffs (due to the way SSE implements float rounding). Provided the diffs are below JND, the human eye cannot physically detect the color difference.
Message was sent while issue was closed.
Description was changed from ========== Add AdobeRGB1998 Munsell chart layout test Like the sRGB-to-sRGB Munsell chart test, but wider-gamut. Add a Munsell chart AdobeRGB1998 to sRGB color transform test. The test is designed to run in the test harness or manually, and tabulates the dE (per color error from the expected Munsell sRGB colors [1]) and total RMS color error. Since a color transform is applied, this test may produce output colors different from the expected colors, but the RMS error (or score) is what matters. Scores below 2 (2 is the level of a Just Noticeable Difference [JND]) are considered good, and good color correction libraries score well below that on this test [2]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html [2] http://bit.ly/1Gkadze Adobe to sRGB chart tests, QCMS scores less than 0.9 on this test. A similar test has been added to our QCMS tests, issue 532910. BUG=570317 ========== to ========== Add AdobeRGB1998 Munsell chart layout test Like the sRGB-to-sRGB Munsell chart test, but wider-gamut. Add a Munsell chart AdobeRGB1998 to sRGB color transform test. The test is designed to run in the test harness or manually, and tabulates the dE (per color error from the expected Munsell sRGB colors [1]) and total RMS color error. Since a color transform is applied, this test may produce output colors different from the expected colors, but the RMS error (or score) is what matters. Scores below 2 (2 is the level of a Just Noticeable Difference [JND]) are considered good, and good color correction libraries score well below that on this test [2]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html [2] http://bit.ly/1Gkadze Adobe to sRGB chart tests, QCMS scores less than 0.9 on this test. A similar test has been added to our QCMS tests, issue 532910. BUG=570317 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add AdobeRGB1998 Munsell chart layout test Like the sRGB-to-sRGB Munsell chart test, but wider-gamut. Add a Munsell chart AdobeRGB1998 to sRGB color transform test. The test is designed to run in the test harness or manually, and tabulates the dE (per color error from the expected Munsell sRGB colors [1]) and total RMS color error. Since a color transform is applied, this test may produce output colors different from the expected colors, but the RMS error (or score) is what matters. Scores below 2 (2 is the level of a Just Noticeable Difference [JND]) are considered good, and good color correction libraries score well below that on this test [2]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html [2] http://bit.ly/1Gkadze Adobe to sRGB chart tests, QCMS scores less than 0.9 on this test. A similar test has been added to our QCMS tests, issue 532910. BUG=570317 ========== to ========== Add AdobeRGB1998 Munsell chart layout test Like the sRGB-to-sRGB Munsell chart test, but wider-gamut. Add a Munsell chart AdobeRGB1998 to sRGB color transform test. The test is designed to run in the test harness or manually, and tabulates the dE (per color error from the expected Munsell sRGB colors [1]) and total RMS color error. Since a color transform is applied, this test may produce output colors different from the expected colors, but the RMS error (or score) is what matters. Scores below 2 (2 is the level of a Just Noticeable Difference [JND]) are considered good, and good color correction libraries score well below that on this test [2]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html [2] http://bit.ly/1Gkadze Adobe to sRGB chart tests, QCMS scores less than 0.9 on this test. A similar test has been added to our QCMS tests, issue 532910. BUG=570317 Committed: https://crrev.com/41e148e07880590674f5eaf1ba8145da8938709a Cr-Commit-Position: refs/heads/master@{#365715} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/41e148e07880590674f5eaf1ba8145da8938709a Cr-Commit-Position: refs/heads/master@{#365715}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1530153006/ by noel@chromium.org. The reason for reverting is: Reverting this due to back-end infra problems creating rebaselines..
Message was sent while issue was closed.
On 2015/12/17 03:53:08, noel gordon wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/1530153006/ by mailto:noel@chromium.org. > > The reason for reverting is: Reverting this due to back-end infra problems > creating rebaselines.. crbug.com/570401 rebaseline issue on-going.
Message was sent while issue was closed.
Description was changed from ========== Add AdobeRGB1998 Munsell chart layout test Like the sRGB-to-sRGB Munsell chart test, but wider-gamut. Add a Munsell chart AdobeRGB1998 to sRGB color transform test. The test is designed to run in the test harness or manually, and tabulates the dE (per color error from the expected Munsell sRGB colors [1]) and total RMS color error. Since a color transform is applied, this test may produce output colors different from the expected colors, but the RMS error (or score) is what matters. Scores below 2 (2 is the level of a Just Noticeable Difference [JND]) are considered good, and good color correction libraries score well below that on this test [2]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html [2] http://bit.ly/1Gkadze Adobe to sRGB chart tests, QCMS scores less than 0.9 on this test. A similar test has been added to our QCMS tests, issue 532910. BUG=570317 Committed: https://crrev.com/41e148e07880590674f5eaf1ba8145da8938709a Cr-Commit-Position: refs/heads/master@{#365715} ========== to ========== Add AdobeRGB1998 Munsell chart layout test Like the sRGB-to-sRGB Munsell chart test, but wider-gamut. Add a Munsell chart AdobeRGB1998 to sRGB color transform test. The test is designed to run in the test harness or manually, and tabulates the dE (per color error from the expected Munsell sRGB colors [1]) and total RMS color error. Since a color transform is applied, this test may produce output colors different from the expected colors, but the RMS error (or score) is what matters. Scores below 2 (2 is the level of a Just Noticeable Difference [JND]) are considered good, and good color correction libraries score well below that on this test [2]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html [2] http://bit.ly/1Gkadze Adobe to sRGB chart tests, QCMS scores less than 0.9 on this test. A similar test has been added to our QCMS tests, issue 532910. BUG=570317 Committed: https://crrev.com/41e148e07880590674f5eaf1ba8145da8938709a Cr-Commit-Position: refs/heads/master@{#365715} Relanding: with the layout test marked [ NeedsManualRebaseline ] while rebaseline server is being fixed, issue 570401. BUG=570317 ==========
The CQ bit was checked by noel@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org Link to the patchset: https://codereview.chromium.org/1531803002/#ps20001 (title: "Land with [ NeedsManualRebaseline ]")
Description was changed from ========== Add AdobeRGB1998 Munsell chart layout test Like the sRGB-to-sRGB Munsell chart test, but wider-gamut. Add a Munsell chart AdobeRGB1998 to sRGB color transform test. The test is designed to run in the test harness or manually, and tabulates the dE (per color error from the expected Munsell sRGB colors [1]) and total RMS color error. Since a color transform is applied, this test may produce output colors different from the expected colors, but the RMS error (or score) is what matters. Scores below 2 (2 is the level of a Just Noticeable Difference [JND]) are considered good, and good color correction libraries score well below that on this test [2]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html [2] http://bit.ly/1Gkadze Adobe to sRGB chart tests, QCMS scores less than 0.9 on this test. A similar test has been added to our QCMS tests, issue 532910. BUG=570317 Committed: https://crrev.com/41e148e07880590674f5eaf1ba8145da8938709a Cr-Commit-Position: refs/heads/master@{#365715} Relanding: with the layout test marked [ NeedsManualRebaseline ] while rebaseline server is being fixed, issue 570401. BUG=570317 ========== to ========== Add AdobeRGB1998 Munsell chart layout test Like the sRGB-to-sRGB Munsell chart test, but wider-gamut. Add a Munsell chart AdobeRGB1998 to sRGB color transform test. The test is designed to run in the test harness or manually, and tabulates the dE (per color error from the expected Munsell sRGB colors [1]) and total RMS color error. Since a color transform is applied, this test may produce output colors different from the expected colors, but the RMS error (or score) is what matters. Scores below 2 (2 is the level of a Just Noticeable Difference [JND]) are considered good, and good color correction libraries score well below that on this test [2]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html [2] http://bit.ly/1Gkadze Adobe to sRGB chart tests, QCMS scores less than 0.9 on this test. A similar test has been added to our QCMS tests, issue 532910. BUG=570317 Committed: https://crrev.com/41e148e07880590674f5eaf1ba8145da8938709a Cr-Commit-Position: refs/heads/master@{#365715} Relanding: with the layout test marked [ NeedsManualRebaseline ] while the rebaseline server is being fixed, issue 570401. BUG=570317 ==========
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531803002/20001
Message was sent while issue was closed.
Description was changed from ========== Add AdobeRGB1998 Munsell chart layout test Like the sRGB-to-sRGB Munsell chart test, but wider-gamut. Add a Munsell chart AdobeRGB1998 to sRGB color transform test. The test is designed to run in the test harness or manually, and tabulates the dE (per color error from the expected Munsell sRGB colors [1]) and total RMS color error. Since a color transform is applied, this test may produce output colors different from the expected colors, but the RMS error (or score) is what matters. Scores below 2 (2 is the level of a Just Noticeable Difference [JND]) are considered good, and good color correction libraries score well below that on this test [2]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html [2] http://bit.ly/1Gkadze Adobe to sRGB chart tests, QCMS scores less than 0.9 on this test. A similar test has been added to our QCMS tests, issue 532910. BUG=570317 Committed: https://crrev.com/41e148e07880590674f5eaf1ba8145da8938709a Cr-Commit-Position: refs/heads/master@{#365715} Relanding: with the layout test marked [ NeedsManualRebaseline ] while the rebaseline server is being fixed, issue 570401. BUG=570317 ========== to ========== Add AdobeRGB1998 Munsell chart layout test Like the sRGB-to-sRGB Munsell chart test, but wider-gamut. Add a Munsell chart AdobeRGB1998 to sRGB color transform test. The test is designed to run in the test harness or manually, and tabulates the dE (per color error from the expected Munsell sRGB colors [1]) and total RMS color error. Since a color transform is applied, this test may produce output colors different from the expected colors, but the RMS error (or score) is what matters. Scores below 2 (2 is the level of a Just Noticeable Difference [JND]) are considered good, and good color correction libraries score well below that on this test [2]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html [2] http://bit.ly/1Gkadze Adobe to sRGB chart tests, QCMS scores less than 0.9 on this test. A similar test has been added to our QCMS tests, issue 532910. BUG=570317 Committed: https://crrev.com/41e148e07880590674f5eaf1ba8145da8938709a Cr-Commit-Position: refs/heads/master@{#365715} Relanding: with the layout test marked [ NeedsManualRebaseline ] while the rebaseline server is being fixed, issue 570401. BUG=570317 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add AdobeRGB1998 Munsell chart layout test Like the sRGB-to-sRGB Munsell chart test, but wider-gamut. Add a Munsell chart AdobeRGB1998 to sRGB color transform test. The test is designed to run in the test harness or manually, and tabulates the dE (per color error from the expected Munsell sRGB colors [1]) and total RMS color error. Since a color transform is applied, this test may produce output colors different from the expected colors, but the RMS error (or score) is what matters. Scores below 2 (2 is the level of a Just Noticeable Difference [JND]) are considered good, and good color correction libraries score well below that on this test [2]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html [2] http://bit.ly/1Gkadze Adobe to sRGB chart tests, QCMS scores less than 0.9 on this test. A similar test has been added to our QCMS tests, issue 532910. BUG=570317 Committed: https://crrev.com/41e148e07880590674f5eaf1ba8145da8938709a Cr-Commit-Position: refs/heads/master@{#365715} Relanding: with the layout test marked [ NeedsManualRebaseline ] while the rebaseline server is being fixed, issue 570401. BUG=570317 ========== to ========== Add AdobeRGB1998 Munsell chart layout test Like the sRGB-to-sRGB Munsell chart test, but wider-gamut. Add a Munsell chart AdobeRGB1998 to sRGB color transform test. The test is designed to run in the test harness or manually, and tabulates the dE (per color error from the expected Munsell sRGB colors [1]) and total RMS color error. Since a color transform is applied, this test may produce output colors different from the expected colors, but the RMS error (or score) is what matters. Scores below 2 (2 is the level of a Just Noticeable Difference [JND]) are considered good, and good color correction libraries score well below that on this test [2]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html [2] http://bit.ly/1Gkadze Adobe to sRGB chart tests, QCMS scores less than 0.9 on this test. A similar test has been added to our QCMS tests, issue 532910. BUG=570317 Committed: https://crrev.com/41e148e07880590674f5eaf1ba8145da8938709a Cr-Commit-Position: refs/heads/master@{#365715} Relanding: with the layout test marked [ NeedsManualRebaseline ] while the rebaseline server is being fixed, issue 570401. BUG=570317 Committed: https://crrev.com/3a1a10ca2b50dfb459a5dc49036c2e6e9953fc6a Cr-Commit-Position: refs/heads/master@{#366549} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3a1a10ca2b50dfb459a5dc49036c2e6e9953fc6a Cr-Commit-Position: refs/heads/master@{#366549} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
